Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mesa data set #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add mesa data set #1

wants to merge 2 commits into from

Conversation

sqhou
Copy link

@sqhou sqhou commented Sep 25, 2017

I just add a small documentation and a example for MESA data.

@fherwig
Copy link
Member

fherwig commented Sep 25, 2017

  1. Why do you plot log10(s.get('star_age') - why log? Does that make sense? Sometime people plot log of the remaining time. But that is not what this is. You could plot as a function of model number.

  2. No - there is no direct way to extract units from MESA output. But I do believe there is somewhere, either on the mesa web page or in a MESA code paper a table. Maybe someone can find it and put a link into this notebook.

@sqhou can you fix these two items? (for 2 maybe just remove the question, or turn it into a comment?)

@sqhou
Copy link
Author

sqhou commented Sep 26, 2017

Sorry, just show how to operate it, no specific physical meaning. OK, I have added the contents about unit of mesa data.

@fherwig
Copy link
Member

fherwig commented Nov 9, 2017

@sqhou there is now a conflict - can you resolve it please? Someone has change the Star_explore notebook as well, and git can not automatically merger it

@sqhou
Copy link
Author

sqhou commented Nov 10, 2017

I have done as the command line instructions. I wonder is it resolved?

@fherwig
Copy link
Member

fherwig commented Nov 21, 2017

this has still unresolved conflict, maybe checkout Star_explore.ipynb on fresh branch, apply changes and make new pull request, and delete this pull request and branch

@fherwig
Copy link
Member

fherwig commented Feb 14, 2021

This requires manual merge with latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants