Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the required package source for the “Microsoft.Android.Ref.34” package in MAUI test cases #6235

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

CiciLi1
Copy link
Contributor

@CiciLi1 CiciLi1 commented Jan 23, 2025

Bug

Fixes:
https://github.com/NuGet/Client.Engineering/issues/2898

Description

Based on discussion in the bug 2898, add the required package source for the “Microsoft.Android.Ref.34” package in MAUI test cases

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@CiciLi1 CiciLi1 requested a review from nkolev92 January 23, 2025 02:49
@CiciLi1 CiciLi1 requested a review from a team as a code owner January 23, 2025 02:49
@@ -187,6 +189,7 @@ public async Task UninstallPackageForPRInPMC(ProjectTemplate projectTemplate)

await CommonUtility.CreatePackageInSourceAsync(simpleTestPathContext.PackageSource, PackageName, v100);
simpleTestPathContext.Settings.AddSource(NuGetConstants.NuGetHostName, NuGetConstants.V3FeedUrl);
simpleTestPathContext.Settings.AddSource("AndroidFeed", "https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-a8cd27e4/nuget/v3/index.json");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have it 3x, let's use a share string for the feed url.

@CiciLi1 CiciLi1 requested a review from nkolev92 January 24, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants