Refactor: segment-storage #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrlika
requested changes
Aug 26, 2024
packages/p2p-media-loader-core/src/segments-storage/segments-storage.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
mrlika
requested changes
Aug 26, 2024
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segments-storage/segments-storage.interface.ts
Outdated
Show resolved
Hide resolved
mrlika
requested changes
Sep 6, 2024
mrlika
requested changes
Sep 9, 2024
packages/p2p-media-loader-core/src/segments-storage/segments-memory-storage.ts
Outdated
Show resolved
Hide resolved
- Improve segment storage event handling - Update segment storage classes and interfaces - Swap function parameters in correct order - Set memory storage limit based on user agent - Clear segments based on memory storage limit
…classes and interfaces - Refactored the segment-memory-storage.ts file to optimize the memory storage of segments. - Updated the segment storage classes and interfaces to improve performance and efficiency.
- Change the `segmentsMemoryStorageLimit` configuration in the `Core` class to allow for an undefined value, instead of a specific number. This provides more flexibility in managing the memory storage limit for segments. - Update the `CommonCoreConfig` type definition in the `types.ts` file to reflect the change in the `segmentsMemoryStorageLimit` property.
This commit optimizes the segment memory storage by introducing segment storage categories. The new SegmentCategories type is added to classify segments into different categories such as obsolete, beyondHalfHttpWindowBehind, behindPlayback, and aheadHttpWindow. The segment removal logic is updated to use these categories for better organization and efficiency.
…imize segment memory storage
…imize segment memory storage - Added a new function getAvailableMemoryPercent() to calculate the available memory percentage. - Updated the generateQueue() function to pass the available memory percentage to QueueUtils.generateQueue(). - Modified the getUsedMemory() function in SegmentMemoryStorage to return the memory limit and memory used. - Updated the getSegmentPlaybackStatuses() function in utils/stream.ts to calculate the time windows based on the available memory percentage.
This reverts commit 8a631e7.
mrlika
requested changes
Sep 23, 2024
mrlika
approved these changes
Sep 26, 2024
packages/p2p-media-loader-core/src/segment-storage/segment-memory-storage.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segment-storage/segment-memory-storage.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segment-storage/segment-memory-storage.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segment-storage/segment-memory-storage.ts
Outdated
Show resolved
Hide resolved
packages/p2p-media-loader-core/src/segment-storage/segment-memory-storage.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.