refactor: optimize segment storage deletion logic

Novage · Aug 16, 2024 · 36097e3 · 36097e3
1 parent 54ed8fd
commit 36097e3
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/p2p-media-loader-core/src/segments-storage.ts b/packages/p2p-media-loader-core/src/segments-storage.ts
@@ -179,11 +179,11 @@ export class SegmentsMemoryStorage {
       this.logger(`cleared ${itemsToDelete.length} segments`);
       itemsToDelete.forEach((id) => {
         const segment = this.cache.get(id);
-        if (segment) {
-          this.cacheMap.get(segment.streamSwarmId)?.delete(segment.externalId);
-          if (this.cacheMap.get(segment.streamSwarmId)?.size === 0) {
-            this.cacheMap.delete(segment.streamSwarmId);
-          }
+        if (!segment) return;
+
+        this.cacheMap.get(segment.streamSwarmId)?.delete(segment.externalId);
+        if (this.cacheMap.get(segment.streamSwarmId)?.size === 0) {
+          this.cacheMap.delete(segment.streamSwarmId);
         }
 
         this.cache.delete(id);