Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26153: Add a user interface for managing method/block loops in the techniques editor #6119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented Jan 10, 2025

https://issues.rudder.io/issues/26153

⚠️ work in progress

@RaphaelGauthier RaphaelGauthier force-pushed the ust_26153/add_a_user_interface_for_managing_method_block_loops_in_the_techniques_editor branch from e9e412a to dbc488b Compare January 10, 2025 15:52
@RaphaelGauthier RaphaelGauthier added the WIP Use that label for a Work In Progress PR that must not be merged yet label Jan 10, 2025
@RaphaelGauthier
Copy link
Member Author

Here's what it looks like at the moment :

If no foreach has been declared: the ‘Foreach’ tab contains a greyed-out counter :
foreach-disabled

If a foreach has been declared, this badge is highlighted to show this information, and a banner above the method is displayed with the name of the foreach and the number of iterations so that this information is always visible, even when the method is collapsed:
foreach-enabled

To declare a ‘foreach’, user must enter the name and keys of this iterator, then validate to activate the feature :
foreach-creation

Once the foreach has been declared, the user can modify the name and keys, and add new items on which to iterate.
⚠️ For the moment, this interface isn't finished, so here's a look at how it looks now, compared with the result we're aiming for :
foreach-edit-WIP
foreach-edit-goal

Here is the list of things to finish:

  • enable iterator editing (name, keys and items)
  • do the same for Blocks
  • add a copy-to-clipboard on the banner
  • decode, store and encode the foreach list correctly
  • add a warning before deleting the foreach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Use that label for a Work In Progress PR that must not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant