Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add digital ch triggers #486

Merged
merged 14 commits into from
Feb 4, 2025
Merged

Feat/add digital ch triggers #486

merged 14 commits into from
Feb 4, 2025

Conversation

tsvetelinpetrov
Copy link
Contributor

No description provided.

@tsvetelinpetrov tsvetelinpetrov added doc required This PR includes user-facing changes that need to be documented. ui not required All PRs either need "ui required" or "ui not required". labels Jan 27, 2025
@tsvetelinpetrov tsvetelinpetrov changed the base branch from main to feat/add-trigger-bias February 3, 2025 14:24
kylebonnici
kylebonnici approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kylebonnici kylebonnici left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos nice work 👍

Just add changes to change log and coordinate with @ketile with UI Changes.

src/actions/deviceActions.ts Outdated Show resolved Hide resolved
src/actions/deviceActions.ts Outdated Show resolved Hide resolved
@kylebonnici kylebonnici added ui required All PRs either need "ui required" or "ui not required". and removed ui not required All PRs either need "ui required" or "ui not required". labels Feb 4, 2025
@tsvetelinpetrov
Copy link
Contributor Author

tsvetelinpetrov commented Feb 4, 2025 •
edited
Loading

@ketile
There are 2 new elements added to the UI:
image

  1. Trigger type selection (Digital/Analog)
  2. Under the "Trigger settings" - Options tor configuring the triggering pattern.
    image

The level for the analog trigger is moved under "Trigger settings"
image

There is also a small problem to consider - the dropdown menu can "blend" with the other dropdowns:
image

@tsvetelinpetrov tsvetelinpetrov merged commit a9af19b into feat/add-trigger-bias Feb 4, 2025
2 checks passed
@tsvetelinpetrov tsvetelinpetrov deleted the feat/add-digital-ch-triggers branch February 4, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebonnici kylebonnici kylebonnici approved these changes

Assignees
No one assigned
Labels
doc required This PR includes user-facing changes that need to be documented. ui required All PRs either need "ui required" or "ui not required".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsvetelinpetrov @kylebonnici