Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buildscript, Fix Misc Bugs #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IntegerLimit
Copy link

@IntegerLimit IntegerLimit commented Jul 5, 2024

This PR updates the buildscripts of this project to use GregTech CEu's Buildscripts, fixes the Teleporter replacing non-full blocks with obsidian (e.g. chests), and fixes the display of Custom Cakes in TOP.

Outcomes:

  • The project can once again be developed and built
  • The Teleporter now only replaces air, or blocks with a material of air (e.g. invisible lights generated by the feral flare lantern)
  • Custom Cakes:
    • Now have proper names in The One Probe
    • Pick Block (creative) now works on them correctly
    • Allows removal of custom waila handlers, not needed now that Pick Block works properly

@IntegerLimit
Copy link
Author

From the Nomi-CEu Issue linked above:

The voiding issue is actually really easy to reproduce:

  1. Go to the void world with the void world cake, and replace one of the obsidian blocks with a chest. You can place something inside the chest if you would like.
  2. Go to the overworld via any method
  3. Go to the void world with the void world cake. Chest gets replaced by obsidian (due to the check being for fullBlock instead of air

@IntegerLimit
Copy link
Author

As of b413f16 (#36), teleporter has changed:

  • The obsidian platform now once again replaces both air blocks and non-full blocks with obsidian (same as previous behaviour)
  • The replacement of air now occurs as long as the block is not air (instead of only on full blocks)
    • This check was implemented, instead of replacing it always, to prevent issues such as deletion of feral flare lights, and unnecessary replacements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant