Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import grouping #701

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Import grouping #701

merged 2 commits into from
Dec 8, 2023

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Dec 8, 2023

Part of #155

This is fairly standard practice - we group the imports in the std > external libraries > current crate categories, separated by newlines.

Some links:

@Xanewok Xanewok requested a review from a team as a code owner December 8, 2023 14:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: f03c3ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

OmarTawfik
OmarTawfik reviewed Dec 8, 2023
View reviewed changes
.rustfmt.toml
# rustfmt nightly configuration options:
# https://github.com/rust-lang/rustfmt/blob/master/Configurations.md
#

group_imports = "StdExternalCrate"
Copy link
Contributor

@OmarTawfik OmarTawfik Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

What do you think about setting imports_granularity = "Crate" as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a great fan of Module and so I didn't want to fight this battle in this PR 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 😅 alright. Let's talk about it later.

OmarTawfik
OmarTawfik approved these changes Dec 8, 2023
View reviewed changes
.rustfmt.toml
# rustfmt nightly configuration options:
# https://github.com/rust-lang/rustfmt/blob/master/Configurations.md
#

group_imports = "StdExternalCrate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 😅 alright. Let's talk about it later.

@Xanewok Xanewok added this pull request to the merge queue Dec 8, 2023
Merged via the queue into NomicFoundation:main with commit 68b8a93 Dec 8, 2023
1 check passed
@Xanewok Xanewok deleted the import-grouping branch December 8, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xanewok @OmarTawfik