Finish setting up rustc/Clippy lints and fix those #695

Xanewok · 2023-12-04T23:57:22Z

Part of #155

Commit messages have a bit more context on the relevant changes.

I've decided to drop very few lints from the EDR list like deny-by-default ones, inconsistent_struct_constructor (not that useful) or implicit_clone (a lot of false-positives/unidiomatic suggestions; let's wait for Rust 1.74 and rust-lang/rust-clippy#11281 to include it again) or irrelevant ones for us like suboptimal_flops.

Nowadays, this is mostly a leftover that still includes `elided_lifetimes_in_paths`, see rust-lang/rust#91639 for the tracking issue.

They're pretty much what EDR settled for and serves as a good baseline. If we find we're limited by some lints, we can easily turn it off or include some more if we find them valuable.

This is already on-by-default and linted against by the compiler, so let's not make more noise by adding more extraneous warnings here.

changeset-bot · 2023-12-04T23:57:25Z

⚠️ No Changeset found

Latest commit: 2983ff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

crates/solidity/testing/sanctuary/src/main.rs

.cargo/config.toml

crates/solidity/outputs/cargo/crate/src/main.rs

OmarTawfik

Left two concerns about error output from CLIs. Otherwise, LGTM!

Prefer linting against default ones and attempt to lint against some pedantic ones with select, documented exceptions.

crates/infra/cli/src/toolchains/napi/cli.rs

crates/solidity/testing/sanctuary/src/reporting.rs

.cargo/config.toml

crates/codegen/parser/runtime/src/cst.rs

crates/codegen/parser/runtime/src/parse_error.rs

crates/infra/utils/src/lib.rs

crates/infra/utils/src/cargo/workspace.rs

crates/solidity/testing/sanctuary/src/main.rs

crates/infra/cli/src/toolchains/napi/cli.rs

.cargo/config.toml

OmarTawfik

Looking great! thanks.

Xanewok added 4 commits December 5, 2023 00:53

Warn against rust_2018_idioms

c933557

Nowadays, this is mostly a leftover that still includes `elided_lifetimes_in_paths`, see rust-lang/rust#91639 for the tracking issue.

Fix some minor Clippy annoyances

48a52d4

Establish additional Clippy lints we want to warn against

3314a74

They're pretty much what EDR settled for and serves as a good baseline. If we find we're limited by some lints, we can easily turn it off or include some more if we find them valuable.

Don't explicitly warn against nonstandard_style

fea982a

This is already on-by-default and linted against by the compiler, so let's not make more noise by adding more extraneous warnings here.

Xanewok requested a review from a team as a code owner December 4, 2023 23:57

Xanewok commented Dec 4, 2023

View reviewed changes

crates/solidity/testing/sanctuary/src/main.rs Outdated Show resolved Hide resolved

Xanewok commented Dec 5, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

Xanewok changed the title ~~Warn clippy~~ Warn against quite a few additional Clippy lints Dec 5, 2023

OmarTawfik reviewed Dec 5, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 5, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 5, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 5, 2023

View reviewed changes

crates/solidity/outputs/cargo/crate/src/main.rs Show resolved Hide resolved

OmarTawfik requested changes Dec 5, 2023

View reviewed changes

Xanewok added 4 commits December 5, 2023 12:29

Don't lint against the entire rust_2018_idioms group

c3c3f20

Warn against all default lints in Clippy

f7c5a13

Remove some unnecessary clippy::restriction lints

cd1010f

Pick a simpler set of Clippy rules that we want to follow

2b9527e

Prefer linting against default ones and attempt to lint against some pedantic ones with select, documented exceptions.

Xanewok changed the title ~~Warn against quite a few additional Clippy lints~~ Finish setting up rustc/Clippy lints and fix those Dec 5, 2023

Xanewok commented Dec 5, 2023

View reviewed changes

crates/infra/cli/src/toolchains/napi/cli.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/solidity/testing/sanctuary/src/reporting.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

.cargo/config.toml Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/codegen/parser/runtime/src/cst.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/codegen/parser/runtime/src/parse_error.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/infra/utils/src/lib.rs Outdated Show resolved Hide resolved

Xanewok added 4 commits December 6, 2023 13:50

Use structured exit codes in select CLIs

1db2bee

Remove a leftover allow lint

48f73a9

Explicitly print ratio without precision in sanctuary testing progress

f433200

fixup: Actually specify the zero precision

05379fc

Xanewok added 3 commits December 6, 2023 14:36

Appease clippy::match_wildcard_for_single_variants

8582d28

Lint against leftover dbg/todo macros only in CI

301ad8e

Prefer is_some_and over map_or(false, ..)

594056b

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/infra/utils/src/cargo/workspace.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/solidity/testing/sanctuary/src/main.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

crates/infra/cli/src/toolchains/napi/cli.rs Outdated Show resolved Hide resolved

OmarTawfik reviewed Dec 6, 2023

View reviewed changes

.cargo/config.toml Show resolved Hide resolved

OmarTawfik approved these changes Dec 6, 2023

View reviewed changes

Xanewok added 4 commits December 6, 2023 22:27

Use Rayon's panic_fuse to not spawn more threads on panic

fb73560

Use a concrete receiver type when mapping

25b624b

Merge remote-tracking branch 'upstream/main' into warn-clippy

124467f

Use -Dwarnings in CI

cfba852

OmarTawfik mentioned this pull request Dec 7, 2023

Rust Linting #155

Closed

Allow the case_sensitive_file_extension_comparisons lint

2983ff0

Xanewok enabled auto-merge December 7, 2023 09:58

Xanewok added this pull request to the merge queue Dec 7, 2023

Merged via the queue into NomicFoundation:main with commit 0868683 Dec 7, 2023
1 check passed

Xanewok deleted the warn-clippy branch December 7, 2023 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Finish setting up rustc/Clippy lints and fix those #695

Finish setting up rustc/Clippy lints and fix those #695

Xanewok commented Dec 4, 2023

changeset-bot bot commented Dec 4, 2023 •

edited

Loading

OmarTawfik left a comment

OmarTawfik left a comment

Finish setting up rustc/Clippy lints and fix those #695

Finish setting up rustc/Clippy lints and fix those #695

Conversation

Xanewok commented Dec 4, 2023

changeset-bot bot commented Dec 4, 2023 • edited Loading

⚠️ No Changeset found

OmarTawfik left a comment

Choose a reason for hiding this comment

OmarTawfik left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Dec 4, 2023 •

edited

Loading