Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't explicitly specify not_followed_by to disambiguate scanners #688

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Don't explicitly specify not_followed_by to disambiguate scanners #688

merged 3 commits into from
Dec 4, 2023

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Dec 2, 2023 •
edited
Loading

Part of #638

This leverages the existing trie construction for the literal scanners. By not explicitly disambiguating ourselves, we won't have to be careful about missing something when updating the grammar.

cc @OmarTawfik since we talked about this recently

@Xanewok
Don't explicitly specify not_followed_by to disambiguate scanners
fb255ff 
This leverages the existing trie construction for the literal scanner.
By not explicitly disambiguating ourselves, we won't have to be careful
about missing something when updating the grammar.
@Xanewok Xanewok requested a review from a team as a code owner December 2, 2023 17:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2cf2b9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Xanewok Xanewok enabled auto-merge December 4, 2023 10:01
@Xanewok Xanewok added this pull request to the merge queue Dec 4, 2023
Merged via the queue into NomicFoundation:main with commit 3619746 Dec 4, 2023
1 check passed
@Xanewok Xanewok deleted the not-not-followed-by branch December 4, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xanewok @OmarTawfik