Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix import statements grammar #678

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix import statements grammar #678

merged 1 commit into from
Nov 28, 2023

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Nov 27, 2023 •
edited by Xanewok
Loading

  • fix v2 to use the same name as v0/v1 for PathImport and NamedImport
  • sync all three versions to use the same names for ImportDeconstruction and UsingDeconstruction, which is consistent with similar node kinds in the grammar.
  • also fixed a few versioning bugs in v1, that seemed to cause more issues downstream.

Ref #652

@OmarTawfik
fix import statements grammar
b66e0ad 
- fix v2 to use the same name as v0/v1 for `PathImport` and `NamedImport`
- sync all three versions to use the same names for `ImportDeconstruction` and `UsingDeconstruction`, which is consistent with similar node kinds in the grammar.
- also fixed a few versioning bugs in v1, that seemed to cause more issues downstream.
@OmarTawfik OmarTawfik requested a review from a team as a code owner November 27, 2023 23:43
@OmarTawfik OmarTawfik enabled auto-merge November 27, 2023 23:43
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2023

⚠️ No Changeset found

Latest commit: b66e0ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Xanewok
Xanewok approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new names. Thanks!

@OmarTawfik OmarTawfik added this pull request to the merge queue Nov 28, 2023
Merged via the queue into NomicFoundation:main with commit 383d426 Nov 28, 2023
1 check passed
@OmarTawfik OmarTawfik deleted the fix-import-statements-grammar branch November 28, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok