Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove flakey cursor perf tests #630

Merged
merged 1 commit into from
Nov 2, 2023
Merged

remove flakey cursor perf tests #630

merged 1 commit into from
Nov 2, 2023

Conversation

OmarTawfik
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: f5c9db2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review November 2, 2023 05:13
@OmarTawfik OmarTawfik requested a review from a team as a code owner November 2, 2023 05:13
@OmarTawfik OmarTawfik enabled auto-merge November 2, 2023 05:14
Xanewok
Xanewok approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing this but we could probably keep the threshold very low (x2) to not regress this, since it's crucial for the VS Code extension reasonable perf when using Slang as I understand it.

@OmarTawfik OmarTawfik added this pull request to the merge queue Nov 2, 2023
Merged via the queue into NomicFoundation:main with commit 113dfc9 Nov 2, 2023
@OmarTawfik OmarTawfik deleted the remove-flakey-tests branch November 2, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok