Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct keyword versioning #622

Merged

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Oct 25, 2023

  • Split every KeywordItem into multiple KeywordDefinitions, each having their own versioning. This is to account for things like fixed8x8 and fixed256x80 being reserved/unreserved in different versions.
  • Duplicate keywords between Solidity and Yul, since the same keyword can be reserved in different versions between the two.
  • Now all keywords have correct versioning.
  • Added a script that will fetch solc binaries and test all variants of keywords (10777) against the actual compiler output. It has a few hacks around parsing/skipping errors, so it is not stable enough (yet) to run in CI/unguided, but it definitely helped running locally and observing the output.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: c57ffe7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review October 25, 2023 14:57
@OmarTawfik OmarTawfik requested a review from a team as a code owner October 25, 2023 14:57
@OmarTawfik OmarTawfik force-pushed the reserved-keywords-compat branch from 4a206a6 to c57ffe7 Compare October 26, 2023 14:34
@OmarTawfik OmarTawfik enabled auto-merge October 27, 2023 10:56
@OmarTawfik OmarTawfik added this pull request to the merge queue Oct 27, 2023
Merged via the queue into NomicFoundation:main with commit e37d803 Oct 27, 2023
1 check passed
@OmarTawfik OmarTawfik deleted the reserved-keywords-compat branch October 27, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants