Expose cursor method in napi #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 73ebd6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AntonyBlakey
force-pushed
the
AntonyBlakey/add-cursor-to-napi
branch
from
e58579e to
3f9332d
Compare
OmarTawfik
reviewed
Oct 23, 2023
| } | ||
| export class TokenNode { | ||
| get type(): NodeType.Token; | ||
| get kind(): TokenKind; | ||
| get textLength(): TextIndex; | ||
| get text(): string; | ||
| get cursor(): Cursor; |
There was a problem hiding this comment.
I suggest adding a unit test that checks/asserts the cursor results in TypeScript.
There was a problem hiding this comment.
I want to do that with the Iter work. But I will add a gumby test at least.
OmarTawfik
approved these changes
Oct 23, 2023
AntonyBlakey
force-pushed
the
AntonyBlakey/add-cursor-to-napi
branch
from
1e8ea50 to
73ebd6c
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/[email protected] ### Patch Changes - [#615](#615) [`06cbbe8`](06cbbe8) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - `cursor` method is now exposed in Typescript API Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.