Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the infra test cargo command to run more tests. #1218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

Modify the infra test cargo command to run more tests. #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/infra/cli/src/commands/test/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,10 @@ fn test_cargo() -> Result<()> {

Command::new("cargo")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!

solidity_testing_perf contains two kinds of tests, the benchmarks (which need valgrind), and the the same logic ran as unit tests (without measuring) to ensure they are correct in CI. So I think this would disable both kinds.

I tried using per test overrides to exclude only the benchmark tests, but the test runner fails due to an external issue (I filed a bug here).

In the meantime, WDYT of adding a second explicit command after it, to make sure both run in CI?

# Run all tests in 'solidity_testing_perf' excluding the benchmarks (which need valgrind installed on the system):
cargo nextest run --package "solidity_testing_perf" --workspace --all-features --lib --bins --examples --no-fail-fast

.args(["nextest", "run"])
.args(["--exclude", "solidity_testing_perf"]) // Requires callgrind, which may not be available
.flag("--workspace")
.flag("--all-features")
.flag("--lib")
.flag("--bins")
.flag("--examples")
.flag("--all-targets")
.flag("--no-fail-fast")
.add_build_rustflags()
.run();
Expand Down
Loading