-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ParseOutput
to return a NonTerminal
instead of a Node
#1187
Change ParseOutput
to return a NonTerminal
instead of a Node
#1187
Conversation
🦋 Changeset detectedLatest commit: 6615c18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
06692b6
to
95137a0
Compare
crates/codegen/runtime/cargo/crate/src/runtime/parser/parse_output.rs
Outdated
Show resolved
Hide resolved
crates/codegen/runtime/cargo/crate/src/runtime/parser/parser_support/parser_function.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions. Otherwise, LGTM!
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the remaining comments. Thanks!
crates/codegen/runtime/cargo/crate/src/runtime/compilation/internal_builder.rs
Outdated
Show resolved
Hide resolved
crates/codegen/runtime/cargo/crate/src/runtime/parser/parser_support/parser_function.rs
Outdated
Show resolved
Hide resolved
crates/codegen/runtime/cargo/crate/src/runtime/parser/parser_support/parser_function.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions. Otherwise, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I suggest adding a changeset about this.
Solves #1184
To go on top of #1172
This has a big impact in the failing examples, which now return the expected
NonTerminal
.This was acknowledgedly coded by playing the whack-a-mole with the type system. I'm not so happy with the bunch of
Rc::clone()
that leaked out; I will consider an alternative once we settle this is what we need and there are no more pressing issues.Currently doing a full CI run locally to find what more to fix. In the meantime, I'll mark this as draft.