Adding binding rules to typeof(<enum>).min and max, and to <enum>.<member> so they work with extensions
#1177
Conversation
|
There was a problem hiding this comment.
I think this needs rebasing on latest main.
cc @ggiraldez if you don't mind a quick review?
|
I suppose it's best to wait for #1149 to be in sync with main, and then rebase this one on top of it |
crates/solidity/testing/snapshots/bindings_output/expressions/type_expr/input.sol
Outdated
Show resolved
Hide resolved
beta-ziliani
force-pushed
the
beta/1158
branch
from
9bfd79f to
0a578b3
Compare
There was a problem hiding this comment.
This file is a left over from #1196, but it doesn't harm to have it here
beta-ziliani
changed the title
typeof(<enum>).min and max, and to <enum>.<member> so they work with extensions
|
This is ready for another review.
I think the issue is addressed in bd2ad90. I still don't understand why CI was not showing a problem on my end. |
| if (version-matches ">= 0.6.8") { | ||
| edge def -> @enum.value_ref_typeof | ||
| } |
There was a problem hiding this comment.
This should not be version restricted. I tried in Remix and binding enum members work for all our supported versions (eg. >= 0.4.11).
| using Id for Answer; | ||
|
|
||
| function testFunc() returns (Answer) { | ||
| Answer.Yes.id(); |
There was a problem hiding this comment.
This should resolve for all versions, but you'll need to move the enum inside the library because top-level enums are not supported before 0.6.0.
Fixes #1158.
Fixes #1196.
Considerations:
It's built on top of Solidity binding fixes driven by Sanctuary #1149It's rebased on master.It's currently missing a test formaxI adapted an existing test, though maybe it's preferred to add a different one?using for, so it can very well be moved to theusingfolder.EDITED