Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run benchmarking in CI #1051

Merged
merged 1 commit into from
Aug 3, 2024
Merged

run benchmarking in CI #1051

merged 1 commit into from
Aug 3, 2024

Conversation

OmarTawfik
Copy link
Contributor

This updates our workflows to reuse devcontainer image in github actions, which is needed to run benchmarking tests in CI using the same valgrind binaries we install in the devcontainer.

Also moved the cache steps to a common action to avoid duplication.

@OmarTawfik OmarTawfik requested a review from a team as a code owner July 30, 2024 13:45
Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: bdecf90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik enabled auto-merge July 30, 2024 13:46
@OmarTawfik OmarTawfik disabled auto-merge July 30, 2024 14:16
@OmarTawfik OmarTawfik force-pushed the OmarTawfik/gh-actions-container branch 5 times, most recently from 5ab498d to ce0260d Compare July 30, 2024 20:17
@OmarTawfik OmarTawfik marked this pull request as draft July 31, 2024 05:58
@OmarTawfik OmarTawfik force-pushed the OmarTawfik/gh-actions-container branch 3 times, most recently from a72f4d6 to 9dbb7bc Compare August 2, 2024 23:09
This is needed to run benchmarking tests in CI using the same `valgrind` binaries we install in the devcontainer.
Also moved the cache steps to a common action to avoid duplication.
@OmarTawfik OmarTawfik force-pushed the OmarTawfik/gh-actions-container branch from 9dbb7bc to bdecf90 Compare August 3, 2024 02:34
@OmarTawfik OmarTawfik marked this pull request as ready for review August 3, 2024 02:34
@OmarTawfik OmarTawfik enabled auto-merge August 3, 2024 02:34
@OmarTawfik OmarTawfik added this pull request to the merge queue Aug 3, 2024
Merged via the queue into main with commit 99ff53f Aug 3, 2024
3 checks passed
@OmarTawfik OmarTawfik deleted the OmarTawfik/gh-actions-container branch August 3, 2024 07:58
ggiraldez pushed a commit to manastech/slang that referenced this pull request Aug 6, 2024
This updates our workflows to reuse devcontainer image in github
actions, which is needed to run benchmarking tests in CI using the same
`valgrind` binaries we install in the devcontainer.

Also moved the cache steps to a common action to avoid duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants