Skip to content

Commit

Permalink
Modify the infra test cargo command to run more tests.
Browse files Browse the repository at this point in the history
Previously, the command used to run tests was `cargo nextest run --workspace --all-features --lib --bins --examples --no-fail-fast`. This command ended up skipping the tests in the `metaslang` packages. We can run these as well by changing the command to `cargo nextest run --workspace --exclude solidity_testing_perf --all-features --all-targets --no-fail-fast`.

`--exclude solidity_testing_perf` is required because it tries to link with callgrind, which will not be available on all platforms. It's possible that this crash was the reason for the original restrictions in the first place, but I don't know for sure. We can think about different ways to conditionally run those tests in the future, if it's wanted.
  • Loading branch information
mjoerussell committed Jan 15, 2025
1 parent 6389361 commit f299714
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions crates/infra/cli/src/commands/test/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,10 @@ fn test_cargo() -> Result<()> {

Command::new("cargo")
.args(["nextest", "run"])
.args(["--exclude", "solidity_testing_perf"]) // Requires callgrind, which may not be available
.flag("--workspace")
.flag("--all-features")
.flag("--lib")
.flag("--bins")
.flag("--examples")
.flag("--all-targets")
.flag("--no-fail-fast")
.add_build_rustflags()
.run();
Expand Down

0 comments on commit f299714

Please sign in to comment.