pr feedback

NomicFoundation · Dec 4, 2023 · b7161a5 · b7161a5
1 parent 41474e0
commit b7161a5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -66,7 +66,7 @@ solidity_testing_utils = { path = "crates/solidity/testing/utils" }
 #
 # External
 #
-anyhow = { version = "1.0.70", features = ["backtrace", "std"] }
+anyhow = { version = "1.0.75", features = ["backtrace", "std"] }
 ariadne = { version = "0.2.0" }
 bson = { version = "2.6.1" }
 cargo-emit = { version = "0.2.1" }

diff --git a/crates/solidity/testing/solc/src/utils/binaries.rs b/crates/solidity/testing/solc/src/utils/binaries.rs
@@ -82,12 +82,13 @@ fn fetch_releases(mirror_url: &Url, binaries_dir: &Path) -> Result<HashMap<Versi
 
     let list_path = binaries_dir.join("list.json");
 
-    let download_fresh_list = match list_path.metadata() {
-        Err(_) => true,
+    let should_download_list = match list_path.metadata() {
+        Err(err) if err.kind() == std::io::ErrorKind::NotFound => true,
+        Err(err) => return Err(err)?,
         Ok(metadata) => metadata.created()?.elapsed()? > Duration::from_secs(60 * 60 * 24),
     };
 
-    if download_fresh_list {
+    if should_download_list {
         let list_url = mirror_url.join("list.json")?;
         download_file(list_url, &list_path)?;
     }