Skip to content

Commit

Permalink
turn on clippy::wildcard_imports
Browse files Browse the repository at this point in the history
cc @Xanewok for context:

#680 (comment)
  • Loading branch information
OmarTawfik committed Dec 3, 2023
1 parent b496d36 commit 5cebd98
Show file tree
Hide file tree
Showing 43 changed files with 163 additions and 93 deletions.
4 changes: 4 additions & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@ lto = true

[build]
rustflags = [
# rustc additional warnings:
"--warn",
"unused_crate_dependencies",
# clippy additional warnings:
"--warn",
"clippy::wildcard_imports",
# This is a list of allowed Clippy rules for the purposes of gradual migration.
# See https://github.com/NomicFoundation/slang/pull/626
"-A",
Expand Down
5 changes: 4 additions & 1 deletion crates/codegen/grammar/src/grammar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ use std::collections::{BTreeSet, HashMap};

use semver::Version;

use super::*;
use super::{
GrammarVisitor, ParserDefinitionRef, PrecedenceParserDefinitionRef, ScannerDefinitionRef,
TriviaParserDefinitionRef, Visitable,
};

pub struct Grammar {
pub name: String,
Expand Down
5 changes: 4 additions & 1 deletion crates/codegen/grammar/src/parser_definition.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
use std::fmt::Debug;
use std::rc::Rc;

use super::*;
use super::{
GrammarVisitor, PrecedenceParserDefinitionRef, ScannerDefinitionRef, VersionQualityRange,
Visitable,
};

pub trait ParserDefinition: Debug {
fn name(&self) -> &'static str;
Expand Down
4 changes: 3 additions & 1 deletion crates/codegen/grammar/src/precedence_parser_definition.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
use std::fmt::Debug;
use std::rc::Rc;

use super::*;
use super::{
GrammarVisitor, ParserDefinitionNode, ParserDefinitionRef, VersionQualityRange, Visitable,
};

pub trait PrecedenceParserDefinition: Debug {
fn name(&self) -> &'static str;
Expand Down
2 changes: 1 addition & 1 deletion crates/codegen/grammar/src/scanner_definition.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use std::fmt::Debug;
use std::rc::Rc;

use super::*;
use super::{GrammarVisitor, VersionQualityRange, Visitable};

pub trait ScannerDefinition: Debug {
fn name(&self) -> &'static str;
Expand Down
6 changes: 5 additions & 1 deletion crates/codegen/grammar/src/visitor.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
use super::*;
use super::{
Grammar, ParserDefinitionNode, ParserDefinitionRef, PrecedenceParserDefinitionNode,
PrecedenceParserDefinitionRef, ScannerDefinitionNode, ScannerDefinitionRef,
TriviaParserDefinitionRef,
};

pub trait GrammarVisitor {
fn grammar_enter(&mut self, _grammar: &Grammar) {}
Expand Down
6 changes: 5 additions & 1 deletion crates/codegen/parser/runtime/src/cst.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ use std::rc::Rc;

use serde::Serialize;

use super::{cursor::Cursor, kinds::*, text_index::TextIndex};
use super::{
cursor::Cursor,
kinds::{RuleKind, TokenKind},
text_index::TextIndex,
};

#[derive(Clone, Debug, PartialEq, Eq, Serialize)]
pub struct RuleNode {
Expand Down
2 changes: 1 addition & 1 deletion crates/codegen/parser/runtime/src/cursor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::rc::Rc;

use super::{
cst::{Node, RuleNode},
kinds::*,
kinds::{RuleKind, TokenKind},
text_index::{TextIndex, TextRange},
};

Expand Down
5 changes: 4 additions & 1 deletion crates/codegen/parser/runtime/src/kinds.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#[cfg(feature = "slang_napi_interfaces")]
use {napi::bindgen_prelude::*, napi_derive::napi};
use {
napi::bindgen_prelude::{FromNapiValue, ToNapiValue},
napi_derive::napi,
};

#[derive(
Debug,
Expand Down
10 changes: 8 additions & 2 deletions crates/codegen/parser/runtime/src/napi/napi_cst.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
use std::rc::Rc;

use {
napi::{bindgen_prelude::*, JsObject, NapiValue},
napi::{
bindgen_prelude::{Env, FromNapiValue, ToNapiValue},
JsObject, NapiValue,
},
napi_derive::napi,
};

use super::*;
use super::{
napi_cursor, napi_text_index, RuleKind, RustNode, RustRuleNode, RustTextIndex, RustTokenNode,
TokenKind,
};
use napi_cursor::Cursor;
use napi_text_index::TextIndex;

Expand Down
8 changes: 4 additions & 4 deletions crates/codegen/parser/runtime/src/napi/napi_cursor.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use {
napi::{bindgen_prelude::*, JsObject},
napi::{bindgen_prelude::Env, JsObject},
napi_derive::napi,
};

use super::*;
use napi_cst::*;
use napi_text_index::*;
use super::{napi_cst, napi_text_index, RuleKind, RustCursor, TokenKind};
use napi_cst::ToJS;
use napi_text_index::{TextIndex, TextRange};

#[napi(namespace = "cursor")]
pub struct Cursor(Box<RustCursor>);
Expand Down
4 changes: 2 additions & 2 deletions crates/codegen/parser/runtime/src/napi/napi_parse_error.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use napi_derive::napi;

use super::*;
use napi_text_index::*;
use super::{napi_text_index, RustParseError};
use napi_text_index::TextRange;

#[napi(namespace = "parse_error")]
#[derive(PartialEq, Clone)]
Expand Down
6 changes: 3 additions & 3 deletions crates/codegen/parser/runtime/src/napi/napi_parse_output.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use {napi::bindgen_prelude::*, napi_derive::napi};
use {napi::bindgen_prelude::Env, napi_derive::napi};

use super::*;
use napi_cst::*;
use super::{napi_cst, napi_cursor, napi_parse_error, RustParseOutput};
use napi_cst::ToJS;

#[napi(namespace = "parse_output")]
pub struct ParseOutput(RustParseOutput);
Expand Down
2 changes: 1 addition & 1 deletion crates/codegen/parser/runtime/src/napi/napi_text_index.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use napi_derive::napi;

use super::*;
use super::{RustTextIndex, RustTextRange};

#[napi(object, namespace = "text_index")]
#[derive(Copy, Clone)]
Expand Down
22 changes: 11 additions & 11 deletions crates/codegen/parser/runtime/src/support/mod.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
pub mod choice_helper;
pub mod context;
pub mod optional_helper;
pub mod parser_function;
pub mod parser_result;
pub mod precedence_helper;
pub mod recovery;
pub mod repetition_helper;
pub mod separated_helper;
pub mod sequence_helper;
mod choice_helper;
mod context;
mod optional_helper;
mod parser_function;
mod parser_result;
mod precedence_helper;
mod recovery;
mod repetition_helper;
mod separated_helper;
mod sequence_helper;

#[macro_use]
pub mod scanner_macros;
Expand All @@ -18,7 +18,7 @@ pub use optional_helper::OptionalHelper;
pub use parser_function::ParserFunction;
pub use parser_result::ParserResult;
pub use precedence_helper::PrecedenceHelper;
pub use recovery::*;
pub use recovery::RecoverFromNoMatch;
pub use repetition_helper::{OneOrMoreHelper, ZeroOrMoreHelper};
pub use separated_helper::SeparatedHelper;
pub use sequence_helper::SequenceHelper;
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use super::{
text_index::TextIndex,
},
context::ParserContext,
parser_result::*,
parser_result::{IncompleteMatch, Match, ParserResult, SkippedUntil},
};

pub trait ParserFunction<L>
Expand Down
6 changes: 5 additions & 1 deletion crates/codegen/parser/runtime/src/support/parser_result.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
use super::super::{cst, kinds::*, text_index::TextIndex};
use super::super::{
cst,
kinds::{RuleKind, TokenKind},
text_index::TextIndex,
};

#[derive(PartialEq, Eq, Clone, Debug)]
pub enum ParserResult {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pub trait IsLexicalContext {

#[allow(non_snake_case)]
pub mod LexicalContextType {
use super::*;
use super::{IsLexicalContext, LexicalContext};

{%- for context in code.scanner_contexts %}
pub struct {{ context.name }} {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ use super::{
kinds::{RuleKind, TokenKind, ProductionKind, IsLexicalContext, LexicalContextType},
lexer::Lexer,
parse_output::ParseOutput,
support::*,
support::{
ChoiceHelper, OneOrMoreHelper, OptionalHelper, ParserContext, ParserFunction, ParserResult,
PrecedenceHelper, RecoverFromNoMatch, SeparatedHelper, SequenceHelper, ZeroOrMoreHelper,
},
};

pub use super::kinds::LexicalContext;
Expand Down
6 changes: 5 additions & 1 deletion crates/solidity/outputs/cargo/crate/src/generated/cst.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/solidity/outputs/cargo/crate/src/generated/kinds.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions crates/solidity/outputs/cargo/crate/src/generated/support/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5cebd98

Please sign in to comment.