Skip to content

Commit

Permalink
fix ci queue (#1089)
Browse files Browse the repository at this point in the history
changesets PRs unfortunately don't queue CI checks automatically [due to
GitHub
limitations](https://github.com/orgs/community/discussions/57484). This
leads to us having a workaround to manually close/reopen each PR before
merging it, to trigger the right workflows. Which in turn, interferes
with the deduplication check in the CI workflow. I'm removing it here to
unblock merging #1080.
A bit wasteful, but I don't think it is worth spending more time on for
now.
  • Loading branch information
OmarTawfik authored Aug 27, 2024
1 parent d86151b commit 261cc9e
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,13 @@ on:

# In the event that there is a new push to the ref, cancel any running jobs because they are now obsolete, wasting resources.
concurrency:
group: "${{ github.workflow }}-${{ github.ref_name }}"
group: "${{ github.workflow }}-${{ github.ref_name }}-${{ github.event_name }}"
cancel-in-progress: true

jobs:
ci:
runs-on: "ubuntu-22.04" # _SLANG_DEV_CONTAINER_BASE_IMAGE_ (keep in sync)

# Due to the "on" events above, this workflow will run on every push to any branch, and on every PR.
# This means that if a PR is created from a branch in the main repo, the CI jobs will run twice.
# This condition deduplicats it, so that it either runs on a push (to main repo or forks) or on a PR (from forks only).
if: "${{ github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != 'NomicFoundation/slang') }}"

steps:
- name: "Checkout Repository"
uses: "actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332"
Expand Down

0 comments on commit 261cc9e

Please sign in to comment.