Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NodeJS version used in CI #533

Merged
merged 2 commits into from
Dec 5, 2023
Merged

update NodeJS version used in CI #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1521bbb
update NodeJS/VS Code version used in CI
OmarTawfik Nov 29, 2023
7df9ba1
roll back vscode version update
OmarTawfik Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/add-issue-to-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ jobs:
add-to-project:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: "18.x"

- uses: actions/[email protected]
with:
project-url: https://github.com/orgs/NomicFoundation/projects/5
github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}
7 changes: 6 additions & 1 deletion .github/workflows/add-label-to-new-issue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ jobs:
issues: write
pull-requests: write
steps:
- uses: actions/github-script@v6
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: "18.x"

- uses: actions/github-script@v7
with:
script: |
const issue = await github.rest.issues.get({
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ jobs:

steps:
- name: Clone repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "14.x"
node-version: "18.x"

- name: npm latest
run: npm i -g npm@8 && npm i -g npm@latest
Expand Down Expand Up @@ -79,12 +79,9 @@ jobs:
key: ${{ runner.os }}-vscode-1.70.2

- name: Run E2E tests
uses: GabrielBB/xvfb-action@v1.0
uses: coactions/setup-xvfb@v1.0.1
with:
run: npm run test:e2e
env:
CODE_VERSION: ${{ matrix.version }}
OmarTawfik marked this conversation as resolved.
Show resolved Hide resolved
VSCODEGO_BEFORE_RELEASE_TESTS: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed VSCODEGO_BEFORE_RELEASE_TESTS: true as I couldn't find any usage for it in the repo, and the only reference to it online seems like internal config used by the VSCode Go extension repository:

https://github.com/golang/vscode-go/blob/d8333230d2cac81aeb952a4d51e2fd2b06e0a472/.github/workflows/test-long-all.yml#L56-L61

https://github.com/golang/vscode-go/blob/d8333230d2cac81aeb952a4d51e2fd2b06e0a472/test/integration/install.test.ts#L278-L283


- name: Package the extension
run: npm run package
7 changes: 7 additions & 0 deletions client/src/popups/showAnalyticsAllowPopup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
window,
ExtensionContext,
ConfigurationTarget,
ExtensionMode,
} from "vscode";

const PREVIOUSLY_SHOWN_TELEMETRY_LABEL = "previouslyShownTelemetryMessage";
Expand All @@ -12,6 +13,12 @@ export async function showAnalyticsAllowPopup({
}: {
context: ExtensionContext;
}): Promise<void> {
if (context.extensionMode === ExtensionMode.Test) {
OmarTawfik marked this conversation as resolved.
Show resolved Hide resolved
// Dialog messages are prohibited in tests:
// https://github.com/microsoft/vscode/blob/36fefc828e4c496a7bbb64c63f3eb3052a650f8f/src/vs/workbench/services/dialogs/common/dialogService.ts#L56
return;
}

// TODO: remove this once we are happy we have most people reconfirmed
await context.globalState.update("shownTelemetryMessage", undefined);

Expand Down
Loading