update NodeJS version used in CI (#533)

.github/workflows/add-issue-to-project.yml

@@ -10,7 +10,12 @@ jobs:
   add-to-project:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/[email protected]
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: "18.x"
+
+      - uses: actions/[email protected]
         with:
           project-url: https://github.com/orgs/NomicFoundation/projects/5
           github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}

.github/workflows/add-label-to-new-issue.yml

@@ -13,7 +13,12 @@ jobs:
       issues: write
       pull-requests: write
     steps:
-      - uses: actions/github-script@v6
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: "18.x"
+
+      - uses: actions/github-script@v7
         with:
           script: |
             const issue = await github.rest.issues.get({

.github/workflows/ci.yaml

@@ -19,12 +19,12 @@ jobs:
 
     steps:
       - name: Clone repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: "14.x"
+          node-version: "18.x"
 
       - name: npm latest
         run: npm i -g npm@8 && npm i -g npm@latest
@@ -79,12 +79,9 @@ jobs:
           key: ${{ runner.os }}-vscode-1.70.2
 
       - name: Run E2E tests
-        uses: GabrielBB/xvfb-action@v1.0
+        uses: coactions/setup-xvfb@v1.0.1
         with:
           run: npm run test:e2e
-        env:
-          CODE_VERSION: ${{ matrix.version }}
-          VSCODEGO_BEFORE_RELEASE_TESTS: true
 
       - name: Package the extension
         run: npm run package

client/src/popups/showAnalyticsAllowPopup.ts

@@ -3,6 +3,7 @@ import {
   window,
   ExtensionContext,
   ConfigurationTarget,
+  ExtensionMode,
 } from "vscode";
 
 const PREVIOUSLY_SHOWN_TELEMETRY_LABEL = "previouslyShownTelemetryMessage";
@@ -12,6 +13,12 @@ export async function showAnalyticsAllowPopup({
 }: {
   context: ExtensionContext;
 }): Promise<void> {
+  if (context.extensionMode === ExtensionMode.Test) {
+    // Dialog messages are prohibited in tests:
+    // https://github.com/microsoft/vscode/blob/36fefc828e4c496a7bbb64c63f3eb3052a650f8f/src/vs/workbench/services/dialogs/common/dialogService.ts#L56
+    return;
+  }
+
   // TODO: remove this once we are happy we have most people reconfirmed
   await context.globalState.update("shownTelemetryMessage", undefined);