Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: switch to forge-std for JS integration tests #770

Merged
merged 2 commits into from
Jan 17, 2025
Merged

test: switch to forge-std for JS integration tests #770

merged 2 commits into from
Jan 17, 2025

Conversation

agostbiro
Copy link
Member

Switch to forge-std for Solidity test JS integration tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5bc409f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Jan 15, 2025
@agostbiro agostbiro self-assigned this Jan 15, 2025
@agostbiro agostbiro requested a review from fvictorio January 15, 2025 12:20
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 12:20 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 12:20 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 12:21 — with GitHub Actions Inactive
agostbiro
agostbiro commented Jan 15, 2025
View reviewed changes
js/integration-tests/solidity-tests/contracts/ContractEnvironment.t.sol

function testContextIsTest() public {
assertEq(vm.isContext(Vm.ExecutionContext.Test), true);
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test case, because the execution context doesn't seem to be exposed from forge-std and it's unnecessary anyway: there is an identical Rust integration test.

@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 12:21 — with GitHub Actions Inactive
@agostbiro agostbiro had a problem deploying to github-action-benchmark January 15, 2025 12:21 — with GitHub Actions Error
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 13:08 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 13:09 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 13:09 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 13:09 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark January 15, 2025 13:09 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit f6583fe into feat/solidity-tests Jan 17, 2025
41 checks passed
@agostbiro agostbiro deleted the test/switch-to-forge-std branch January 17, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Wodann approved these changes

@fvictorio fvictorio fvictorio approved these changes

Assignees

@agostbiro agostbiro

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agostbiro @fvictorio @Wodann