Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feat/multichain #765

Merged
merged 32 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
52c5f0c
Duplicate stack trace logic in Rust
agostbiro Dec 3, 2024
0c4eaea
wip
fvictorio Dec 4, 2024
2d89c1c
Set throwOnTransactionFailures true and get tx hash from error
agostbiro Dec 4, 2024
f24182a
refactor: pass tracing config to provider (#738)
agostbiro Dec 5, 2024
8baaad9
Remove solidity_trace getter from Response
agostbiro Dec 5, 2024
1190ac4
Remove duplicated NAPI logic
agostbiro Dec 5, 2024
7c7be60
remove getContractAndFunctionNameCallback
agostbiro Dec 6, 2024
9114f1c
Add link_hex_string_bytecode back to edr_napi
fvictorio Dec 6, 2024
6ac3b7a
Adapt hardhat patch to latest changes
fvictorio Dec 6, 2024
29d9aa1
Remove unused stuff in hardhat-tests
fvictorio Dec 6, 2024
6c3f143
Refactor for type safety
agostbiro Dec 10, 2024
591d921
Make build model Send + Sync
agostbiro Dec 19, 2024
2c4320c
Add hardhat_addCompilationResult
agostbiro Dec 19, 2024
b8ee8e3
Remove hardhat_getStackTraceFailuresCount logic
fvictorio Dec 20, 2024
a8181b0
Fix missing argument in test
fvictorio Dec 20, 2024
8ef72fa
Fix lint:fix script in hardhat-tests
fvictorio Dec 20, 2024
6766851
Remove useless code
fvictorio Dec 20, 2024
afb44be
Ignore dot-notation rule for private field
fvictorio Dec 20, 2024
25b95de
Fix compilation issues in edr_napi ts tests
fvictorio Dec 20, 2024
dd12489
Move lock inside contract decoder
agostbiro Dec 20, 2024
61828d5
Fix naming
agostbiro Dec 20, 2024
f62886b
Add test for hardhat_addCompilationResult
fvictorio Dec 23, 2024
323aa5b
Cleanup stack traces tests code
fvictorio Dec 23, 2024
d419f36
Create dirty-humans-exercise.md
fvictorio Dec 23, 2024
993ea66
Upgrade Hardhat dependency
fvictorio Dec 27, 2024
d692778
Export a get_latest_supported_solc_version function
fvictorio Dec 27, 2024
2d66ae5
Make `stackTrace` throw on error
agostbiro Dec 30, 2024
5fd0f03
Adapt tests and patch to new .stackTrace() semantics
fvictorio Dec 30, 2024
47e003b
Add TODO comments
agostbiro Jan 2, 2025
215b180
Fix imports
agostbiro Jan 2, 2025
1bf9175
edr-0.7.0 (#762)
github-actions[bot] Jan 2, 2025
3415702
Merge remote-tracking branch 'origin/main' into merge/main
Wodann Jan 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 30 additions & 19 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions crates/edr_evm/src/trace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ pub struct Trace<HaltReasonT: HaltReasonTrait> {
#[derive(Clone, Debug)]
pub struct Step {
/// The program counter
pub pc: u64,
pub pc: u32,
/// The call depth
pub depth: u64,
/// The executed op code
Expand Down Expand Up @@ -515,7 +515,10 @@ impl<HaltReasonT: HaltReasonTrait> TraceCollector<HaltReasonT> {
None
};
self.current_trace_mut().add_step(Step {
pc: interp.program_counter() as u64,
pc: interp
.program_counter()
.try_into()
.expect("program counter fits into u32"),
depth: data.journaled_state.depth(),
opcode: interp.current_opcode(),
stack,
Expand Down
1 change: 1 addition & 0 deletions crates/edr_generic/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ edr_eth = { path = "../edr_eth" }
edr_evm = { path = "../edr_evm" }
edr_provider = { path = "../edr_provider" }
edr_rpc_eth = { path = "../edr_rpc_eth" }
edr_solidity = { path = "../edr_solidity" }
log = { version = "0.4.17", default-features = false }
serde = { version = "1.0.209", default-features = false, features = ["derive"] }
thiserror = { version = "1.0.37", default-features = false }
Expand Down
5 changes: 3 additions & 2 deletions crates/edr_generic/tests/integration/issue_570.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::str::FromStr as _;
use std::{str::FromStr as _, sync::Arc};

use edr_eth::{l1, B256};
use edr_evm::hardfork;
Expand All @@ -7,10 +7,10 @@ use edr_provider::{
hardhat_rpc_types::ForkConfig, test_utils::create_test_config_with_fork, time::CurrentTime,
MethodInvocation, NoopLogger, Provider, ProviderError, ProviderRequest,
};
use edr_solidity::contract_decoder::ContractDecoder;
use edr_test_utils::env::get_alchemy_url;
use serial_test::serial;
use tokio::runtime;

// SAFETY: tests that modify the environment should be run serially.

fn get_provider() -> anyhow::Result<Provider<GenericChainSpec>> {
Expand Down Expand Up @@ -39,6 +39,7 @@ fn get_provider() -> anyhow::Result<Provider<GenericChainSpec>> {
logger,
subscriber,
config,
Arc::<ContractDecoder>::default(),
CurrentTime,
)?)
}
Expand Down
6 changes: 6 additions & 0 deletions crates/edr_napi/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @nomicfoundation/edr

## 0.7.0

### Minor Changes

- d419f36: Add a `stackTrace` getter to the provider's response and remove the old, lower-level `solidityTrace` getter.

## 0.6.5

### Patch Changes
Expand Down
Loading
Loading