Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use genesis state instead of genesis accounts #755

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Dec 19, 2024

This PR adds support for setting of a full genesis state instead of just genesis accounts. This functionality is now also exposed to Hardhat where it will be used to set the genesis state of a LocalBlockchain or to overwrite accounts in the ForkedBlockchain.

In the process of updating the pnpm patch, I also:

  • upgraded to Hardhat 2.22.17
  • adopted const constructors for beacon root related constants

Follow-up work

@Wodann Wodann self-assigned this Dec 19, 2024
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 7d45404

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann had a problem deploying to github-action-benchmark December 19, 2024 10:16 — with GitHub Actions Error
@Wodann Wodann temporarily deployed to github-action-benchmark December 19, 2024 10:23 — with GitHub Actions Inactive
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 21.62162% with 116 lines in your changes missing coverage. Please review.

Project coverage is 54.21%. Comparing base (7d71ee6) to head (7d45404).
Report is 1 commits behind head on feat/multichain.

Files with missing lines Patch % Lines
crates/edr_napi/src/config.rs 0.00% 46 Missing ⚠️
crates/edr_napi/src/chains/l1.rs 0.00% 40 Missing ⚠️
crates/edr_napi/src/cast.rs 0.00% 18 Missing ⚠️
crates/edr_provider/src/config.rs 53.84% 6 Missing ⚠️
crates/edr_napi/src/account.rs 0.00% 3 Missing ⚠️
crates/edr_evm/src/blockchain/forked.rs 50.00% 1 Missing ⚠️
crates/edr_napi_core/src/provider/config.rs 0.00% 1 Missing ⚠️
crates/edr_provider/src/data.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/multichain     #755      +/-   ##
===================================================
- Coverage            54.38%   54.21%   -0.17%     
===================================================
  Files                  243      243              
  Lines                28241    28342     +101     
  Branches             28241    28342     +101     
===================================================
+ Hits                 15358    15365       +7     
- Misses               11956    12050      +94     
  Partials               927      927              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann had a problem deploying to github-action-benchmark December 19, 2024 13:36 — with GitHub Actions Failure
@Wodann Wodann had a problem deploying to github-action-benchmark December 19, 2024 22:21 — with GitHub Actions Failure
@Wodann Wodann requested a review from a team December 19, 2024 22:34
@Wodann Wodann marked this pull request as ready for review December 19, 2024 22:35
@Wodann Wodann had a problem deploying to github-action-benchmark December 20, 2024 10:46 — with GitHub Actions Failure
@Wodann Wodann merged commit 53aa8bf into feat/multichain Dec 20, 2024
38 of 41 checks passed
@Wodann Wodann deleted the feat/predeploys branch December 20, 2024 10:58
@Wodann
Copy link
Member Author

Wodann commented Dec 20, 2024

Merging to expedite inclusion in the release/optimism branch. I'll handle any requests for change in follow-up PRs 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant