Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimism Sepolia hardfork #725

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix: Optimism Sepolia hardfork #725

merged 4 commits into from
Nov 5, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Nov 3, 2024

This fixes an incorrect chain ID for the OP Sepolia testnet.

It also adds a test. To support this test, I needed to perform a small refactor to expose the ProviderTestFixture and make it chain-specific.

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Nov 3, 2024
@Wodann Wodann requested review from alcuadrado and a team November 3, 2024 10:34
@Wodann Wodann self-assigned this Nov 3, 2024
Copy link

changeset-bot bot commented Nov 3, 2024

⚠️ No Changeset found

Latest commit: 3262115

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark November 3, 2024 10:34 — with GitHub Actions Inactive
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 66.20690% with 49 lines in your changes missing coverage. Please review.

Project coverage is 53.51%. Comparing base (e977cf2) to head (3262115).
Report is 1 commits behind head on feat/multichain.

Files with missing lines Patch % Lines
crates/edr_provider/src/data.rs 7.69% 0 Missing and 36 partials ⚠️
crates/edr_provider/src/test_utils.rs 92.00% 0 Missing and 8 partials ⚠️
crates/edr_provider/src/requests/eth/gas.rs 0.00% 0 Missing and 4 partials ⚠️
...ates/edr_provider/src/requests/eth/transactions.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/multichain     #725      +/-   ##
===================================================
- Coverage            53.51%   53.51%   -0.01%     
===================================================
  Files                  236      236              
  Lines                27743    27742       -1     
  Branches             27743    27742       -1     
===================================================
- Hits                 14847    14846       -1     
  Misses               11977    11977              
  Partials               919      919              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann temporarily deployed to github-action-benchmark November 5, 2024 14:05 — with GitHub Actions Inactive
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@Wodann Wodann merged commit 70e0111 into feat/multichain Nov 5, 2024
16 checks passed
@Wodann Wodann deleted the fix/op-sepolia branch November 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants