Fixes for static PIE executables #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2020
|
@rcombs could you rebase? |
Growing the section can require changing its position, which results in crashes if the code relies on a symbol within it (e.g. _DYNAMIC). Instead, we can usually find an entry that isn't actually required and replace it.
|
Done. |
|
It seems that PRs with tests are preferred :) #225 |
Mic92
reviewed
Jul 31, 2020
| debug("shifting new PT_LOAD segment by %d bytes to work around a Linux kernel bug\n", startOffset - startPage); | ||
| startPage = startOffset; |
There was a problem hiding this comment.
no, it unconditionally applies it...
Mic92
reviewed
Aug 21, 2021
| debug("shifting new PT_LOAD segment by %d bytes to work around a Linux kernel bug\n", startOffset - startPage); | ||
| startPage = startOffset; | ||
| } | ||
| startPage = startOffset; |
There was a problem hiding this comment.
I understand why isExecutable was removed as a conditional but not why startPage = startOffset was moved out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably, this attempts to avoid growing the dynamic section when adding an rpath, since that results in repositioning the section, which means that existing IP-relative references to the
_DYNAMICsymbol will become invalid.