Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-slim: fix dynamically compiled docker-slim go binaries should be statically linked #373029

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinLoeper
Copy link
Contributor

@MartinLoeper MartinLoeper commented Jan 11, 2025

Fix #371787

The dynamically linked executable slim-sensor fails to execute when it is copied and run by slim build. We are better off to statically link the go executable instead. The docker-slim maintainer confirmed they are also statically linking the binary when distributing it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mbrgm @Br1ght0ne @marsam

Add a 👍 reaction to pull requests you find important.

@MartinLoeper
Copy link
Contributor Author

Before this PR:

file ./result/bin/slim-sensor
./result/bin/slim-sensor: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /nix/store/65h17wjrrlsj2rj540igylrx7fqcd6vq-glibc-2.40-36/lib/ld-linux-x86-64.so.2, stripped

After this PR:

file ./result/bin/slim-sensor
./result/bin/slim-sensor: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped

The other binary which is named slim is not modified. It is also not copied into non-nix environments and thus must not be statically compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-slim: exec /opt/_slim/bin/slim-sensor: no such file or directory
1 participant