Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages.smtcoq: don't build currently-broken specific veriT #369217

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Dec 29, 2024

coqPackages.smtcoq is broekn because its specific version of veriT no longer compiles since #354627 (more precisely commit 7b0b389 )
This disactivates veriT as a short term workardound to fix the CI of the Coq Nix toolbox (as seen for instance in coq-community/coq-nix-toolbox#305

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: coq "A formal proof management system" label Dec 29, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 29, 2024
@proux01 proux01 marked this pull request as ready for review December 30, 2024 08:37
@proux01
Copy link
Contributor Author

proux01 commented Dec 30, 2024

@vbgl CI green both here and on coq-community/coq-nix-toolbox#307

As a longer term solution, we'll probably need an update of https://www.lri.fr/~keller/Documents-recherche/Smtcoq/veriT9f48a98.tar.gz (FWIW nix-build -A veriT perfectly works on master, cc @ckeller )

@vbgl vbgl merged commit 0018055 into NixOS:master Jan 6, 2025
39 checks passed
@vbgl
Copy link
Contributor

vbgl commented Jan 6, 2025

Thanks for the fix. Is smtcoq useful without veriT?

@proux01 proux01 deleted the fix_smtcoq branch January 6, 2025 11:49
@proux01
Copy link
Contributor Author

proux01 commented Jan 6, 2025

No idea
Thanks for the merge!

proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Jan 6, 2025
@ckeller
Copy link

ckeller commented Jan 8, 2025

Thanks for the fix!
@vbgl SMTCoq can be useful without veriT, as veriT is only one possible backend.
In the long term, @arjunvish is working on a port to the last version of veriT.
In the middle term, I plan to maintain the version that is currently supported by SMTCoq. Adding making it compile for Coq Nix to my TODO list.

@vbgl
Copy link
Contributor

vbgl commented Jan 8, 2025

Thank you Chantal for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: coq "A formal proof management system" 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants