Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq: keep compiling master #367074

Merged
merged 1 commit into from
Dec 24, 2024
Merged

coq: keep compiling master #367074

merged 1 commit into from
Dec 24, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Dec 21, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@proux01
Copy link
Contributor Author

proux01 commented Dec 23, 2024

@vbgl CI green both here and on coq-community/coq-nix-toolbox#305 (also tested master on mathcomp: math-comp/math-comp#1316 )

In the longer run, we should rather do an actual rocq package (I'm on it) but meanwhile, this enables to keep testing coq master in CIs.

@vbgl vbgl added the backport release-24.11 Backport PR automatically label Dec 24, 2024
@vbgl vbgl merged commit 531093c into NixOS:master Dec 24, 2024
44 of 45 checks passed
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Dec 24, 2024

Successfully created backport PR for release-24.11:

@proux01
Copy link
Contributor Author

proux01 commented Dec 25, 2024

Thanks

@proux01 proux01 deleted the rocq-master branch December 25, 2024 16:17
proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants