Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{alttpr-opentracker,am2rlauncher,avalonia-ilspy,clr-loader,dafny,formula,ilspycmd,inklecate,knossosnet}: update from .NET 6/7 to .NET 8 #366067

Merged
merged 14 commits into from
Jan 4, 2025

Conversation

GGG-KILLER
Copy link
Contributor

@GGG-KILLER GGG-KILLER commented Dec 18, 2024

Patches the following packages to point to .NET 8.0:

The following have been upgraded to a new version that has support for a newer .NET:

Part of #326335.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GGG-KILLER

This comment was marked as outdated.

@gepbird gepbird self-requested a review December 18, 2024 06:48
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for migrating most of the remaining packages using an EOL .NET and reporting these to upstreams!

Most of the main dotnet related changes look good, and since you did some refactors like moving to finalAttrs, removing with lib;, etc., I left some nits some about general refactor changes. Feel free to ignore if it's too out of scope.

pkgs/by-name/al/alttpr-opentracker/package.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/avalonia-ilspy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ilspycmd/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ilspycmd/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/ilspycmd/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/inklecate/package.nix Show resolved Hide resolved
pkgs/by-name/kn/knossosnet/package.nix Show resolved Hide resolved
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 18, 2024
@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 18, 2024
@GGG-KILLER GGG-KILLER removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 19, 2024
@GGG-KILLER GGG-KILLER requested a review from gepbird December 19, 2024 17:51
@GGG-KILLER

This comment was marked as outdated.

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested each binary (except clr-loader as that's a library) whether their GUI opens or the CLI output looks good on x86_64-linux, no problems! Changes look good too, thanks :)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 20, 2024
Copy link
Contributor

@cdombroski cdombroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out knossosnet; appears to be functional

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 20, 2024
@lafrenierejm
Copy link
Contributor

gh-gei was updated to .NET 8 (and latest version of the individual package) in #366482.

@GGG-KILLER GGG-KILLER added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 21, 2024
@ofborg ofborg bot requested a review from cdombroski December 24, 2024 14:29
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jan 1, 2025
@wegank wegank merged commit 449a025 into NixOS:master Jan 4, 2025
22 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 4, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-366067-to-release-24.11 origin/release-24.11
cd .worktree/backport-366067-to-release-24.11
git switch --create backport-366067-to-release-24.11
git cherry-pick -x f93800ab5ba323dd978eb31f1faff747b8c87c29 aa268be09ae057fffc4a6cbcada68c6865ede8f0 0506ebefc19364bbc1501ea688d300859dfd1147 9255bc2d41bcde82eac88d866fd3d4a504422955 4d1c3d85347cc703cf4e21fa5238f86114684842 59d969cf96b389c2e97c4894836590d8042ace6a 9429734a01f51a590db7fd90e615d551540956a9 1d9621816f3b921de17eb0f4de3a29e9832133b7 2a05f934fcdd6b0269ccfea0efda55e59c4ca634 c9e58193d87d9a5a3571febc30f53689f4f69940 6cd4d4a971ef131d1a436b858eb12fee25c04b67 38a5cfb2fbeca92a7ad46e7f7d119f1ed58440b7 7bf295f2f8446944d8cb92f7ac41d343113e1523 ea961ad641d1e11147628359b2971faf9311d1df

@GGG-KILLER
Copy link
Contributor Author

Can't create the backport PR right now but will do in a few hours
Thank you very much for the merge @wegank ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants