-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{alttpr-opentracker,am2rlauncher,avalonia-ilspy,clr-loader,dafny,formula,ilspycmd,inklecate,knossosnet}: update from .NET 6/7 to .NET 8 #366067
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for migrating most of the remaining packages using an EOL .NET and reporting these to upstreams!
Most of the main dotnet related changes look good, and since you did some refactors like moving to finalAttrs
, removing with lib;
, etc., I left some nits some about general refactor changes. Feel free to ignore if it's too out of scope.
7b36d1a
to
894e78e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested each binary (except clr-loader as that's a library) whether their GUI opens or the CLI output looks good on x86_64-linux, no problems! Changes look good too, thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out knossosnet; appears to be functional
gh-gei was updated to .NET 8 (and latest version of the individual package) in #366482. |
2eb2945
to
19a0427
Compare
19a0427
to
ea961ad
Compare
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-366067-to-release-24.11 origin/release-24.11
cd .worktree/backport-366067-to-release-24.11
git switch --create backport-366067-to-release-24.11
git cherry-pick -x f93800ab5ba323dd978eb31f1faff747b8c87c29 aa268be09ae057fffc4a6cbcada68c6865ede8f0 0506ebefc19364bbc1501ea688d300859dfd1147 9255bc2d41bcde82eac88d866fd3d4a504422955 4d1c3d85347cc703cf4e21fa5238f86114684842 59d969cf96b389c2e97c4894836590d8042ace6a 9429734a01f51a590db7fd90e615d551540956a9 1d9621816f3b921de17eb0f4de3a29e9832133b7 2a05f934fcdd6b0269ccfea0efda55e59c4ca634 c9e58193d87d9a5a3571febc30f53689f4f69940 6cd4d4a971ef131d1a436b858eb12fee25c04b67 38a5cfb2fbeca92a7ad46e7f7d119f1ed58440b7 7bf295f2f8446944d8cb92f7ac41d343113e1523 ea961ad641d1e11147628359b2971faf9311d1df |
Can't create the backport PR right now but will do in a few hours |
Patches the following packages to point to .NET 8.0:
am2rlauncher
(issue upstream: .NET 6 has hit EOL AM2R-Community-Developers/AM2RLauncher#93)avalonia-ilspy
: (issue upstream: .NET 6 has hit EOL icsharpcode/AvaloniaILSpy#151)clr-loader
(no issue upstream because they're just sample projects and not actually built)dafny
(issue upstream: Support dotnet 8 dafny-lang/dafny#4948)formula
(issue upstream: .NET 6 has hit EOL VUISIS/formula-dotnet#42)inklecate
(issue upstream: .NET 6 has hit EOL inkle/ink#922)knossosnet
(issue upstream: .NET 6 has hit EOL KnossosNET/Knossos.NET#259)The following have been upgraded to a new version that has support for a newer .NET:
ilspycmd
(upgrade to preview version was needed because it's the only one that has .NET 8 support):alttpr-opentracker
:Part of #326335.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.