-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invidious: fix playback for proxied video streaming #360926
invidious: fix playback for proxied video streaming #360926
Conversation
edd148e
to
0cc5144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change doesn't fix video playback at all on catgirl.cloud but if it works for you then sure, why not.
@999eagle I've had a look, that's actually another issue. The issue being fixed here is that there is no error message show and the player loading/buffering forever. This is currently only broken if DASH combined with proxied streaming is used. You might need to add |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-360926-to-release-24.11 origin/release-24.11
cd .worktree/backport-360926-to-release-24.11
git switch --create backport-360926-to-release-24.11
git cherry-pick -x 0cc514472fac619bf4634e99963a474ab628847a |
@fpletz can you create the backport manually ? |
Deployed and tested on my invidious instance for 2 weeks.
See iv-org/invidious#4992.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.