Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invidious: fix playback for proxied video streaming #360926

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Dec 2, 2024

Deployed and tested on my invidious instance for 2 weeks.

See iv-org/invidious#4992.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fpletz fpletz force-pushed the pkgs/invidious-fix-proxy-video branch from edd148e to 0cc5144 Compare December 2, 2024 02:16
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360926


x86_64-linux

✅ 1 package built:
  • invidious

aarch64-linux

✅ 1 package built:
  • invidious

x86_64-darwin

✅ 1 package built:
  • invidious

aarch64-darwin

✅ 1 package built:
  • invidious

@GaetanLepage GaetanLepage requested a review from pbsds December 2, 2024 07:44
Copy link
Contributor

@999eagle 999eagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change doesn't fix video playback at all on catgirl.cloud but if it works for you then sure, why not.

@fpletz
Copy link
Member Author

fpletz commented Dec 2, 2024

@999eagle I've had a look, that's actually another issue. The issue being fixed here is that there is no error message show and the player loading/buffering forever. This is currently only broken if DASH combined with proxied streaming is used.

You might need to add services.invidious.sig-helper.enable and generate po_token/visitor_data for your IP/session, see https://docs.invidious.io/installation/#generate-po_token-and-visitor_data-identities. I also needed to fetch videos via a VPN because Youtube blocked the IP ranges of my hoster.

@GaetanLepage GaetanLepage merged commit d3da67a into NixOS:master Dec 2, 2024
20 of 21 checks passed
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-360926-to-release-24.11 origin/release-24.11
cd .worktree/backport-360926-to-release-24.11
git switch --create backport-360926-to-release-24.11
git cherry-pick -x 0cc514472fac619bf4634e99963a474ab628847a

@GaetanLepage
Copy link
Contributor

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

@fpletz can you create the backport manually ?

@fpletz fpletz deleted the pkgs/invidious-fix-proxy-video branch December 2, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants