redlib: 0.35.1-unstable-2024-11-01 -> 0.35.1-unstable-2024-11-22

[bpeetz]

The current version of redlib in nixpkgs is already 20 days old and does no longer work because of a change on reddit's side, see: redlib-org/redlib#324.

I tested this version locally, and it works.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[rnhmjoj]

The test is broken:

redlib[825]:  ERROR redlib::oauth > Failed to create OAuth client. Retrying in 5 seconds...
redlib[825]:  ERROR redlib::oauth > Failed to create OAuth client. Retrying in 5 seconds...

but it has been like this since last week. Can you fix it?

[bpeetz]

@rnhmjoj redlib seems to always try to get a oauth token, which requires sending a request to reddit.com.

We could try to mock the reddit.com host in the test, but this seems rather hacky. Asking upstream, if this auto-connect could be made conditional, would be the other option, but I'm not so sure they would accept something like that, because running redlib offline is probably not a supported configuration.

@Guanran928 as you've reworked the redlib module, do you have an idea on how to avoid this test issue?

[rnhmjoj]

@bpeetz Ok, fixing the test can wait, then.