ycmd: correct gopls package and link path #352222
Conversation
NixOSInfra
added
the
12. first-time contribution
|
Also, I did kinda notice that the YouCompleteMe plugin and its respective server generally haven't really been well maintained in quite a bit. From what it looks like, this issue in particular has been present for almost 4 years. ^^; |
|
I've since moved away from ycmd; in all fairness I'm no longer a maintainer here and would approve a commit removing me from the list if you deem it necessary. |
|
@siriobalmelli If you'd like I can add a commit to this PR removing you from the maintainer role. That's up to you though! Do you think it would be appropriate to add myself as package maintainer? I would like to see the plugin getting some love again! (With approval from the others, of course.) |
wegank
added
12.approvals: 1
|
I'm in favor of removing myself as maintainer and adding you instead, thank you |
github-actions
bot
added
6.topic: vim
8.has: maintainer-list (update)
wegank
removed
12.approvals: 1
ofborg
bot
added
the
11.by: package-maintainer
wegank
added
the
12.approvals: 2
FliegendeWurst
added
the
2.status: merge conflict
|
Please rebase |
This fixes built-in Go completion support in vimPlugins.YouCompleteMe. Previously both an outdated package (gotools) and an outdated binary path were used when installing gopls into ycmd, silently breaking after an upstream update. Signed-off-by: Mel <[email protected]>
Signed-off-by: Mel <[email protected]>
Signed-off-by: Mel <[email protected]>
Signed-off-by: Mel <[email protected]>
melnary
force-pushed
the
ycmd/fix-gopls-path
branch
from
dc020a1 to
11de008
Compare
ofborg
bot
removed
the
2.status: merge conflict
nix-owners
bot
requested review from
mrcjkb,
rvolosatovs,
PerchunPak,
khaneliman,
manveru and
GaetanLepage
|
@SuperSandro2000 Rebased + Updated my contact information while I had the chance :3 |
| mkdir -p $TARGET | ||
| ln -sf ${gotools}/bin/gopls $TARGET | ||
| ln -sf ${gopls}/bin/gopls $TARGET |
There was a problem hiding this comment.
| ln -sf ${gopls}/bin/gopls $TARGET | |
| ln -sf ${lib.getExe gopls} $TARGET |
|
This fixes built-in Go completion support in
vimPlugins.YouCompleteMe.This essentially fixes two problems:
ycmdpreviously used the packagegotoolsto source it'sgoplsbinary from, even though the binary has been removed from there in Update go tools/linters/language servers #85868 and moved to a separate package. Now we use the correctgoplspackage again.These two problems both contributed to
goplsending up a dangling symlink and breaking Go completion in YCM. After this it has been working correctly once again! :3Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.