packetry: init at 0.3.0

[carlossless]

A fast, intuitive USB 2.0 protocol analysis application for use with Cynthion. https://github.com/greatscottgadgets/packetry

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

Related to #81418

[zi3m5f]

Is there a reason you are opening your third PR for the same package?

If it is for the version change please just change PR and commit.

[carlossless]

@zi3m5f

Is there a reason you are opening your third PR for the same package?

I figured that would be more appropriate than bumping the existing pr without changing the version reference in my branch, but I could just name it with an agnostic name.

If it is for the version change please just change PR and commit.

Sure, will do so in the future.

[zi3m5f]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351392

---

x86_64-linux

✅ 1 package built:

• packetry

[zi3m5f]

Suggested change

	postInstall = lib.optionalString (!hostPlatform.isWindows) ''
	rm $out/bin/packetry-cli
	'';

packetry-cli is only needed on windows atm: greatscottgadgets/packetry#154
So we could remove it. Not tested.

The check for windows is not needed so long as meta.platforms doesn't include it but better be safe than sorry?
Upstream builds for windows but I can't test it so I will not suggest adding it to meta.platforms.

[carlossless]

I added this, but I am a little conflicted about adding the hostPlatform check when windows is not part of the supported platforms (in this package.nix).

I am also unaware of how to approach testing the build on windows.

[zi3m5f]

Maybe instead of the check a comment about it being needed only on windows with a link to the pr?

[carlossless]

Yep, I opted to do that instead.

[zi3m5f]

LGTM: builds and gui starts.

Further room for improvement but not necessary right now:

• add desktop item file, see https://github.com/greatscottgadgets/packetry/tree/main/appimage/dist
• maybe enable non gui checks, see separate comment

@carlossless: could you mark the code comments as resolved (minus preCheck), thanks