{bintools-wrapper,cc-wrapper}: factor out Darwin SDK logic, allow paths relative to the Darwin SDK #351315
Conversation
This reduces code duplication, makes the SDK variables available earlier in the wrappers, and makes the behaviour between the two wrappers more consistent.
|
I’ve confirmed that |
`-L` and `-I` are interpreted relative to the `$SDKROOT` by the Darwin toolchain, so we have to avoid filtering out such paths in the purity filter hacks in order to not break e.g. the .NET Core build system. It’s also just the correct thing to do for the platform.
emilazy
force-pushed
the
push-tlytkynvxlmy
branch
from
a468519
to
e047c69
Compare
|
Building |
|
I hate to be the one to tell you this, but FWIW I have built like a thousand derivations with this change to test .NET (which also goes through Swift). |
broken by #349585 the fix is in staging #349589 tho #349585 could get backed out on master and merged to staging so the cc tests work at the end of the release cycle. |
|
Oh, cool. I’ll test the merge then. |
|
FWIW we’re meant to have one more |
|
It still fails because I will open a PR to fix that, but I just undid the tests changes locally for now, and they pass successfully 🎉 Merging on the strength of that, I hope that is okay. |
-Land-Iare interpreted relative to the$SDKROOTby the Darwin toolchain, so we have to avoid filtering out such paths in the purity filter hacks in order to not break e.g. the .NET Core build system. It’s also just the correct thing to do for the platform.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.