Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.AppSqitch: 1.4.0 -> 1.4.1 #351171

Merged
merged 3 commits into from
Oct 27, 2024
Merged

perlPackages.AppSqitch: 1.4.0 -> 1.4.1 #351171

merged 3 commits into from
Oct 27, 2024

Conversation

akegalj
Copy link
Contributor

@akegalj akegalj commented Oct 25, 2024

Bump sqitch tool from v1.4.0 to v1.4.1

This realease https://github.com/sqitchers/sqitch/releases/tag/v1.4.1 mostly contains bug fixes. Most notably:

Updated the locale configuration to fix issues in more recent versions of Perl, and added tests to ensure that the sqitch CLI executes and properly emits localized messages (except on Windows, where the language codes are incompatible).

which is related to sqitch v1.4.0 failing on some machines due too bug in setting a locale. This was fixed here sqitchers/sqitch#806 (comment) and pushed to v1.4.1.

Other comments from release notes don't look like a breaking change. I have checked note:

Tests now require Test::Warn 0.31 or later, as newline handling issues cause test failures in earlier versions. Thanks to Slaven Rezić for the test reports and for identifying the issue.

And this doesn't seem like a breaking change as TestWarn is at version 0.37 https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/perl-packages.nix#L26217

Note: This package doesn't have tests so no automated tests are run

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zakame
Copy link
Member

zakame commented Oct 25, 2024

@ofborg build perl540Packages.AppSqitch

@zakame
Copy link
Member

zakame commented Oct 25, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351171


x86_64-linux

✅ 6 packages built:
  • perl538Packages.AppSqitch
  • perl538Packages.AppSqitch.devdoc
  • perl540Packages.AppSqitch
  • perl540Packages.AppSqitch.devdoc
  • sqitchMysql
  • sqitchPg

pkgs/top-level/perl-packages.nix Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Show resolved Hide resolved
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution and welcome to the project :)

@stigtsp stigtsp requested a review from zakame October 27, 2024 10:06
Copy link
Member

@zakame zakame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and welcome! 🎉 🚀

@stigtsp stigtsp merged commit 23664a7 into NixOS:master Oct 27, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants