Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wivrn: 0.19 -> 0.20 #350069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

PassiveLemon
Copy link
Contributor

@PassiveLemon PassiveLemon commented Oct 20, 2024

Re-take of #349910
Update WiVRn. Since it now requires Qt, it needed to be moved to the category hierarchy

@Titaniumtown

Things done

Move WiVRn to the category hierarchy
Update WiVRn version/hash
Add dependencies (and optionals) for WiVRn, Monado, and the Qt dashboard.
Added a desktop item for the dashboard.
Added cmake flags.
Added patch for Monado and change to use upstream patch script.
*Added patch to fix qt dashboard build failure. (If upstream releases the patch, I'll merge it back)

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PassiveLemon
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
❌ 1 package failed to build:
  • wivrn

@PassiveLemon
Copy link
Contributor Author

Unfortunately, there's a build issue that literally just popped up even there were no changes upstream: WiVRn/WiVRn#154

I am currently using v0.20 on my desktop and it works fine, so I believe some package change in nixpkgs results in this error.

@PassiveLemon PassiveLemon force-pushed the wivrn-update branch 3 times, most recently from c02b821 to 1c41a27 Compare October 20, 2024 17:58
@Titaniumtown
Copy link
Contributor

I'm getting this build error:

AutoRcc subprocess error
------------------------
The rcc process failed to compile
  "SRC:/build/.qt/rcc/wivrn-dashboard_translations.qrc"
into
  "SRC:/build/dashboard/wivrn-dashboard_autogen/GGJYZH3U72/qrc_wivrn-dashboard_translations.cpp"

Command
-------
/nix/store/bgfalfi93kbn8j1wfwz0x0dnk1wx9wdp-qtbase-6.8.0/libexec/rcc -name wivrn_dashboard_translations -o /build/source/build/dashboard/wivrn-dashboard_autogen/GGJYZH3U72/qrc_wivrn-dashboard_translations.cpp /build/source/build/.qt/rcc/wivrn-dashboard_translations.qrc

Output
------
RCC: Error in '/build/source/build/.qt/rcc/wivrn-dashboard_translations.qrc': Cannot find file '/build/source/build/dashboard/wivrn_en.qm'

@Titaniumtown
Copy link
Contributor

Unfortunately, there's a build issue that literally just popped up even there were no changes upstream: WiVRn/WiVRn#154

I am currently using v0.20 on my desktop and it works fine, so I believe some package change in nixpkgs results in this error.

Looks like it is related to: WiVRn/WiVRn@be95ec8

@PassiveLemon
Copy link
Contributor Author

PassiveLemon commented Oct 27, 2024

Since its been like a week and there's been no response, I added the patch and a note about the automatic config defaults

@PassiveLemon
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • wivrn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants