Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refurb: Disable another failing test #348907

Merged
merged 1 commit into from
Oct 27, 2024
Merged

refurb: Disable another failing test #348907

merged 1 commit into from
Oct 27, 2024

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Oct 15, 2024

https://hydra.nixos.org/build/273774875/nixlog/8

=================================== FAILURES ===================================
____________________________ test_mypy_consistence _____________________________

    def test_mypy_consistence() -> None:
        """
        Ensure the visitor method name to node type mappings used in refurb are
        in sync with the ones of mypy.
    
        This is meant as a failsafe, especially when the mypy dependency is
        upgraded.
    
        If this fails, review the mappings in refurb.visitor.METHOD_NODE_MAPPINGS.
        """
    
        mypy_visitor_mapping = get_mypy_visitor_mapping()
>       assert mypy_visitor_mapping == METHOD_NODE_MAPPINGS
E       AssertionError: assert {'visit__prom...peExpr'>, ...} == {'visit__prom...peExpr'>, ...}
E         
E         Omitting 83 identical items, use -vv to show
E         Left contains 1 more item:
E         {'visit_type_alias_stmt': <class 'mypy.nodes.TypeAliasStmt'>}
E         Use -v to get more diff

test/test_visitor.py:82: AssertionError
=========================== short test summary info ============================
FAILED test/test_visitor.py::test_mypy_consistence - AssertionError: assert {'visit__prom...peExpr'>, ...} == {'visit__prom...pe...
=========== 1 failed, 112 passed, 1 skipped, 23 deselected in 26.98s ===========

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@petertriho petertriho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works for me

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4729

@Aleksanaa Aleksanaa merged commit ce8092d into NixOS:master Oct 27, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants