Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: fix update script #326364

Merged
merged 1 commit into from
Jul 13, 2024
Merged

electron: fix update script #326364

merged 1 commit into from
Jul 13, 2024

Conversation

squalus
Copy link
Member

@squalus squalus commented Jul 11, 2024

Description of changes

The nix-universal-prefetch package was deleted in 578d7e7. Switch to nurl.

This code crudely constructs a fixed output derivation and uses nurl to find the hash. I wasn't able to use nurl's simpler mode because it doesn't support postFetch scripts.

Tested an update of electron_29 source package and successfully built the result.

Fixes #321490

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The nix-universal-prefetch package was deleted in 578d7e7. Switch to
nurl.

Fixes NixOS#321490
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yayayayaka yayayayaka merged commit 3ff51e1 into NixOS:master Jul 13, 2024
28 of 29 checks passed
@squalus squalus deleted the electron-update branch July 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electron update script broken
2 participants