Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.ppxlib: 0.30.0 -> 0.32.0 #301752

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

smasher164
Copy link
Contributor

Description of changes

Some 5.1 incompatibilities with ppx are addressed in later versions, e.g. ocaml-ppx/ppxlib#432.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vbgl
Copy link
Contributor

vbgl commented Apr 5, 2024

This breaks vcaml and ppx_cstubs with OCaml 5.1. An easy “fix” might be to mark them as broken.

Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, fixing vcaml and ppx_cstubs turned out to be straightforward.

@vbgl vbgl merged commit aea3d60 into NixOS:master Apr 5, 2024
20 checks passed
@smasher164 smasher164 deleted the ppxlib-32 branch April 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants