-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opusfile: fix windows compilation #120912
Conversation
Oh, I also split And I added myself as maintainer, because my understanding is packages aren't supposed to go maintainerless. I have almost no knowledge of opusfile though. Also added |
Result of 8 packages marked as broken and skipped:
43 packages skipped due to time constraints:
66 packages built successfully:
|
Just added windows as a platform to libopus too. |
Yes.
That is not a per say requirement. It is an advantage but mostly we need people that want the package to work and fix bugs when dependencies change. |
Motivation for this change
Windows openssl got updated recently #108170. Compiling opusfile on windows breaks with openssl 1.1 (see xiph/opusfile#13). I pulled a patch from that issue and it compiles now.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)