Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opusfile: fix windows compilation #120912

Merged
merged 1 commit into from
Apr 30, 2021
Merged

opusfile: fix windows compilation #120912

merged 1 commit into from
Apr 30, 2021

Conversation

Radvendii
Copy link
Contributor

Motivation for this change

Windows openssl got updated recently #108170. Compiling opusfile on windows breaks with openssl 1.1 (see xiph/opusfile#13). I pulled a patch from that issue and it compiles now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Radvendii
Copy link
Contributor Author

Oh, I also split name into pname and version, because that's a thing we're doing now, right?

And I added myself as maintainer, because my understanding is packages aren't supposed to go maintainerless. I have almost no knowledge of opusfile though.

Also added platforms.windows as a valid platform, because it does compile to windows with this patch.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120912 at ee8a004b run on aarch64-linux 1

8 packages marked as broken and skipped:
  • frogatto
  • impressive
  • libsForQt512.k3b
  • libsForQt512.kdenlive
  • libsForQt514.kdenlive
  • python38Packages.rl-coach
  • python39Packages.rl-coach
  • synfigstudio
43 packages skipped due to time constraints:
  • _20kly
  • cantoolz
  • cataclysm-dda
  • cataclysm-dda-git
  • commandergenius
  • crawlTiles
  • dvd-slideshow
  • easyrpg-player
  • endgame-singularity
  • enigma
  • ...
66 packages built successfully:
  • SDL2_mixer
  • _1oom
  • alure2
  • augustus
  • blobwars
  • bpm-tools
  • caudec
  • cdogs-sdl
  • chocolateDoom
  • chromium-bsu
  • cmus
  • craftos-pc
  • crip
  • crispyDoom
  • devilutionx
  • dir2opus
  • easytag (gnome3.easytag)
  • eduke32
  • espeakedit
  • flacon
  • gspeech
  • guile-sdl2
  • haskellPackages.sdl2-mixer
  • haskellPackages.soxlib
  • instead
  • ioquake3
  • iortcw
  • iortcw_sp
  • ivan
  • julius
  • jumpnbump
  • liberal-crime-squad
  • libsForQt5.mlt (libsForQt515.mlt ,plasma5Packages.mlt)
  • libsForQt512.mlt
  • libsForQt514.mlt
  • lyrebird
  • mar1d
  • mkchromecast
  • mlt
  • nxengine-evo
  • opusTools
  • opusfile
  • pell
  • python38Packages.kivy
  • python38Packages.pygame
  • python38Packages.pygame_sdl2
  • python38Packages.pyogg
  • python38Packages.pysdl2
  • python38Packages.scapy
  • python39Packages.kivy
  • python39Packages.pygame
  • python39Packages.pygame_sdl2
  • python39Packages.pyogg
  • python39Packages.pysdl2
  • python39Packages.scapy
  • redoflacs
  • retrofe
  • rocksndiamonds
  • sfrotz
  • slimserver
  • sox
  • squeezelite
  • squishyball
  • taisei
  • trackballs
  • whipper

@Radvendii
Copy link
Contributor Author

Just added windows as a platform to libopus too.

pkgs/applications/audio/opusfile/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/opusfile/default.nix Show resolved Hide resolved
pkgs/applications/audio/opusfile/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/opusfile/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libopus/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Oh, I also split name into pname and version, because that's a thing we're doing now, right?

Yes.

And I added myself as maintainer, because my understanding is packages aren't supposed to go maintainerless. I have almost no knowledge of opusfile though.

That is not a per say requirement. It is an advantage but mostly we need people that want the package to work and fix bugs when dependencies change.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Apr 30, 2021
@SuperSandro2000 SuperSandro2000 merged commit 188d9ad into NixOS:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants