Add dunst service #112100

RocketPuppy · 2021-02-06T06:14:50Z

Motivation for this change

Picking up #58209 and adding examples, defaults, and rebasing on master to fix merge conflicts.

Things done

Dunst config values can be strings, booleans, or integers. These types allow users to intuitively use those. Note that reference configs may encode booleans as "yes" or "no". These work just fine as true/false.

Primarily what's needed here are quoted strings, but each type of value is included for completeness. This is a modified version of lib.generators.mkValueStringDefault.

This is suppressed by simply not specifying an icon path.

I made the choice to merge provided options into the default values because the default values are so large. Default values taken from example dunstrc at dunst 1.5.0.

xaverdh · 2021-02-06T09:10:46Z

Thanks for picking this up, I tested it on my system and looks good so far :)

nixos/modules/services/x11/dunst.nix

It would be misleading to see generators.mkValueStringDefault as the source of an error in the function for converting dunst values. Thinking about that more, dunstValueString is a name that I think adds confusion compared to dunstValue, so I renamed everything to be consistent.

toJSON does what I want here for all cases, simplifiying the logic.

RocketPuppy · 2021-02-06T19:16:40Z

There's something here that I'm not quite happy with when modifying the dunst configuration, and I think it has to do with it being a user service but I'm not too familiar with NixOS's management of that. I nixos-rebuild switch, and the systemd unit shows this line: Feb 06 14:07:45 dwtnixos systemd[1816]: dunst.service: Current command vanished from the unit file, execution of the command list won't be resumed.. I assume this is because NixOS is doing a daemon-reload on the user units, and the command changed because the config file changed. At this point, the new config is not loaded, but restarting the service will load it. However, testing this using notify-send (or any notification that I'm testing) seems to always start a new dunst process that does not use the right config.

RocketPuppy · 2021-02-06T20:00:03Z

Looking into the above some more it seems like the dunst process started by the systemd service isn't connected to the same dbus. Echoing DBUS_SESSION_BUS_ADDRESS in the service gives /run/user/1000/bus, which looks to be from nixos/modules/services/x11/display-managers/default.nix importing that variable. In my terminal however, the value of DBUS_SESSION_BUS_ADDRESS is different, unix:abstract=/tmp/dbus-YmXEExbzhH,guid=3303447c070ed8b1a512da0c601eef32. And a debugging command from the Dunst FAQ, shows no notifications service registered:

 $ gdbus call --session --dest org.freedesktop.DBus --object-path /org/freedesktop/Dbus --method org.freedesktop.DBus.ListNames
(['org.freedesktop.DBus', ':1.30', ':1.3', ':1.2'],)

until I start dunst in a terminal:

$ gdbus call --session --dest org.freedesktop.DBus --object-path /org/freedesktop/Dbus --method org.freedesktop.DBus.ListNames
(['org.freedesktop.DBus', 'org.freedesktop.Notifications', ':1.3', ':1.31', ':1.32', ':1.2'],)

which explains why it would autostart dunst when a notification was sent, and is indicative to me that indeed the systemd dunst is not connecting to the right bus.

rnhmjoj · 2021-02-06T20:10:42Z

I assume this is because NixOS is doing a daemon-reload on the user units, and the command changed because the config file changed.

Correct, nixos-rebuild switch will do a daemon-reload but won't restart user servics. I'm not sure why, but it has been documented in the manual[1].

However, testing this using `notify-send` (or any notification that I'm testing) seems to always start a new dunst process that does not use the right config.

That's most likely due to dbus autostarting dunst, skipping the unit file. I'm not familiar with dbus so I don't know how any of this work, but you could workaround it buy placing the configuration file in /etc/dunst/dunstrc, instead of overriding the `ExecStart`. [1]: https://nixos.org/manual/nixos/unstable/index.html#sect-nixos-systemd-nixos

RocketPuppy · 2021-02-06T23:19:10Z

I'm not familiar with dbus so I don't know how any of this work, but you could workaround it buy placing the configuration file in /etc/dunst/dunstrc, instead of overriding the ExecStart.

I may have to do this if I can't pinpoint the problem soon. Right now I've found that I have three dbus-daemon processes running. Two "user" busses and one system bus. My hunch is there should only be one user bus. Here's a slice of my systemd cgroup tree:

           ├─user.slice
           │ └─user-1000.slice
           │   ├─[email protected]
           │   │ ├─dunst.service
           │   │ │ └─1876 /nix/store/yk40zknzxny71hcqyznjq48wyqw7pdjd-dunst-1.4.1/bin/dunst -config /nix/store/18nkzkwrvskzwz5vhijgzvhgxfrqhbdi-dunstrc -verbosity debug
           │   │ ├─dbus.service
           │   │ │ └─1879 /nix/store/d8ps9nn4fy4byhglqg27svsacg88wiyg-dbus-1.12.16/bin/dbus-daemon --session --address=systemd: --nofork --nopidfile --systemd-activation --syslog-only
           │   └─session-1.scope
           │     ├─1845 /run/current-system/sw/bin/dbus-daemon --syslog --fork --print-pid 5 --print-address 7 --session

Process 1845 is the one that's receiving notifications it seems. At the very least I see logs for the notifications I tested sending. Process 1879 doesn't seem to be logging anywhere, but I imagine that's the bus that dunst (process 1876) is connected to. My question now is: Why is dbus-daemon being launched under my session scope when there is a dbus service for it?

Because it may be relevant now: NixOS version 20.03.3324.929768261a3 (Markhor). I'll try upgrading to 20.09 and see if that fixes the issue.

RocketPuppy · 2021-02-06T23:41:51Z

Because it may be relevant now: NixOS version 20.03.3324.929768261a3 (Markhor). I'll try upgrading to 20.09 and see if that fixes the issue.

Upgrading to 20.09 seems to have fixed my issue. I saw a few issues related to dbus that were closed (I can't find them again now). Perhaps one of those fixed the duplicate daemons.

I'm going to experiment with the daemon-reload now and see if I can get the dunst service to reload with the new config.

RocketPuppy · 2021-02-07T00:56:05Z

It doesn't look like dunst provides any way to reload the configuration of a running process, and even if it did systemd daemon-reload doesn't seem to trigger the ExecReload line. So for now I'll guess I'll just live with the status quo that user services aren't restarted when nixos-rebuild is run. I'm satisfied with this as is.

xaverdh · 2021-02-08T17:20:46Z

For reference here is the dunst issue for implementing config reload in the future: dunst-project/dunst#719

stale · 2021-08-10T03:12:44Z

I marked this as stale due to inactivity. → More info

abathur · 2024-06-29T03:04:38Z

@RocketPuppy Are you still interested in landing this?

RocketPuppy · 2024-07-01T13:59:49Z

@abathur No, apologies. I don't have the time to wrap this up right now.

abathur · 2024-07-01T14:22:35Z

No worries :)

Just doing cleanup so that others don't try to pick it up. I'm going to tentatively close this, but I'm happy to reopen if you ping me.

xaverdh and others added 7 commits February 6, 2021 00:56

nixos/dunst: init

89b1a21

nixos/dunst: config options are representative of full value types

df7d8ac

Dunst config values can be strings, booleans, or integers. These types allow users to intuitively use those. Note that reference configs may encode booleans as "yes" or "no". These work just fine as true/false.

nixos/dunst: refactor indentation

e84e7bb

nixos/dunst: Robustly format Dunst config values

e2dab88

Primarily what's needed here are quoted strings, but each type of value is included for completeness. This is a modified version of lib.generators.mkValueStringDefault.

nixos/dunst: Suppress icon path warning if there is no icon path

14fa9cc

This is suppressed by simply not specifying an icon path.

nixos/dunst: Add missing frame/experimental config options

0eacd7f

nixos/dunst: Add defaults and examples to config options

c6b99fd

I made the choice to merge provided options into the default values because the default values are so large. Default values taken from example dunstrc at dunst 1.5.0.

RocketPuppy changed the title ~~Dw/dunst service~~ Add dunst service Feb 6, 2021

RocketPuppy mentioned this pull request Feb 6, 2021

Add dunst service #58209

Closed

10 tasks

ofborg bot added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 6, 2021

rnhmjoj reviewed Feb 6, 2021

View reviewed changes

nixos/modules/services/x11/dunst.nix Outdated Show resolved Hide resolved

RocketPuppy added 2 commits February 6, 2021 11:31

nixos/dunst: Tighten up dunstValue serialization using toJSON

a839a67

toJSON does what I want here for all cases, simplifiying the logic.

RocketPuppy force-pushed the dw/dunst-service branch from 7eba474 to a839a67 Compare February 6, 2021 18:29

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021

rnhmjoj mentioned this pull request Sep 24, 2021

nixos module for dunst #47398

Open

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 29, 2024

abathur closed this Jul 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dunst service #112100

Add dunst service #112100

RocketPuppy commented Feb 6, 2021 •

edited

Loading

xaverdh commented Feb 6, 2021

RocketPuppy commented Feb 6, 2021

RocketPuppy commented Feb 6, 2021

rnhmjoj commented Feb 6, 2021 via email

RocketPuppy commented Feb 6, 2021

RocketPuppy commented Feb 6, 2021 •

edited

Loading

RocketPuppy commented Feb 7, 2021

xaverdh commented Feb 8, 2021

stale bot commented Aug 10, 2021

abathur commented Jun 29, 2024

RocketPuppy commented Jul 1, 2024

abathur commented Jul 1, 2024

Add dunst service #112100

Add dunst service #112100

Conversation

RocketPuppy commented Feb 6, 2021 • edited Loading

Motivation for this change

Things done

xaverdh commented Feb 6, 2021

RocketPuppy commented Feb 6, 2021

RocketPuppy commented Feb 6, 2021

rnhmjoj commented Feb 6, 2021 via email

RocketPuppy commented Feb 6, 2021

RocketPuppy commented Feb 6, 2021 • edited Loading

RocketPuppy commented Feb 7, 2021

xaverdh commented Feb 8, 2021

stale bot commented Aug 10, 2021

abathur commented Jun 29, 2024

RocketPuppy commented Jul 1, 2024

abathur commented Jul 1, 2024

RocketPuppy commented Feb 6, 2021 •

edited

Loading

RocketPuppy commented Feb 6, 2021 •

edited

Loading