Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page small improvements #1624

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SvMak
Copy link
Contributor

@SvMak SvMak commented Jan 13, 2025

No description provided.

@thilobillerbeck
Copy link
Collaborator

Hi, thanks for creating another pull request. I really have a gripe with this PR that I must address. Sorry to leave you a bit on the dry once again but:

  1. could you please stance what your "small improvements for home page" are and why you see them as an improvement? This changes some colors and effects and also some tags at the same time but what exactly does it improve and why? Just randomly PRing some design change is not really helpful if there is no clearly communicated way of what its all about.
  2. This is rather new but for the future please split up your PRs into functional and design changes as described in the README. This would really help us get PRs merged and forwarded faster since we don't have to stall PRs for long.

Don't get me wrong, splitting components up and introducing proper HTML tags is really appreciated, but I really struggle with the small unexplained styling changes that are present in every of your PRs.

Thanks again for contributing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants