Modify apple/t2/default.nix to use configured efiSysMountPoint #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, this may pass tests but it makes my system nigh-unbootable. So I would probably not recommend this change. |
|
Hmm. Okay. I may have spoken too soon. My laptop can boot, so it's probably not an issue with this module. |
|
So does the change work now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The configured option to use a custom bootx64.efi has a hard-coded path, which doesn't work for users (like myself) who have mounted their ESP in a different place. This PR uses the configured
config.boot.loader.efi.efiSysMountPointas the root dir to look for the EFI file.Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input <- will do once I make this pr :p