Convert Machine::speedFactor from a non-neg int to a non-neg float
#9841
Conversation
The short motivation is to match Hydra, so we can de-dup. The long version is layed out in NixOS#9840.
|
@Ericson2314 @thufschmitt this confuses me a lot. I was just about to update #9526, which is affected by this change (I let it pass that this PR did not update reference documentation because it barely exists yet). I was about to fix it up, but now I'm at loss what to write. Because, which strings are acceptable for being parsed as a float? I can't find any reference documentation for that. My creeping suspicion is that no one actually knows. And seriously, who's supposed to understand what the implementation of Why do we have to make the speed factor a |
|
I am fine if it is just documented as an integer. I made it a |
|
That sounds like adding another bit to the iceberg. It's such a seemingly small thing, but where do we stop if we let this one through? We're constantly discussing about keeping the Nix API surface narrow, and suddenly this. We don't have by far as strict ideas about stability for Hydra. Until you started pouring in PRs it was on life support anyway, we may as well break that one piece. |
|
For remote building, I generally consider Hydra more battled-tested than Nix. The speed factor is just used as a scheduling heuristic: thing like the current machine load are already quite non-deterministic so I don't think extreme precision in that useful here, and a float is useful so you can say some remote build is just a wee bit faster than another. Certainly to me it's nothing like that oddball behavior in the language itself which is a much more serious problem. |
|
This is a very minor and advanced use-case. Consistency is the main desirable property, and it's easier to make Nix a bit more lenient than Hydra stricter. I don't think there's a need to think about it any more than that. |
Convert `Machine::speedFactor` from a non-neg int to a non-neg float (cherry picked from commit 69d0ae2) Change-Id: I2afb5cf9e4fe1384985c58353946135c3d102b42
Motivation
The short motivation is to match Hydra, so we can de-dup.
Context
The long version is layed out in
#9840.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.