Use updated ctap-types with references #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
use-refs
branch
from
67c0952
to
d2971f3
Compare
sosthene-nitrokey
force-pushed
the
use-refs
branch
from
51cc502
to
32240f8
Compare
sosthene-nitrokey
force-pushed
the
use-refs
branch
from
32240f8
to
093e2fb
Compare
sosthene-nitrokey
force-pushed
the
use-refs
branch
from
d8420dd
to
879d9f2
Compare
robin-nitrokey
approved these changes
Oct 19, 2023
src/lib/types.rs
Outdated
| for i in 0..4 { | ||
| wc_magic_number[i] = arr[1 + i]; | ||
| } | ||
| wc_magic_number[..4].copy_from_slice(&arr[1..(4 + 1)]); |
There was a problem hiding this comment.
Nit: I think [1..(4 + 1)] is a bit hard to read, I’d either use [1..5] or, if you want to highlight that the lengths match, [1..][..4].
Not related to this PR, but it looks like there is a check for arr.size() missing here?
There was a problem hiding this comment.
I was surprised that I didn't use [1..][..4], and looking at the history it looks like it came from a cargo clippy --fix.
Will make a clippy issue to see if that can be improved.
There was a problem hiding this comment.
It also added wc_magic_number[..4] that was unnecessary.
|
I can't merge this or add reviewer. @szszszsz can you add the core team to the maintainers? |
sosthene-nitrokey
force-pushed
the
use-refs
branch
from
0354eda
to
9b81a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the updated ctap-types crate that uses references rather than heapless buffers to reduce the total stack usage. See Nitrokey/ctap-types#11