Merge pull request #17 from Nitrokey/clippy-fixes

Fix clippy warnings

src/lib/commands.rs

@@ -1,5 +1,4 @@
 use cbor_smol::cbor_deserialize;
-pub use ctap_types::ctap1::Error as U2fError;
 use heapless::Vec;
 
 use heapless_bytes::{Bytes, Bytes32};
@@ -1146,7 +1145,7 @@ where
             .trussed
             .read_dir_first(w.options.location, rp_rk_dir(rp_id_hash), None,))
         .entry
-        .map(|entry| PathBuf::try_from(entry.path()).unwrap());
+        .map(|entry| PathBuf::from(entry.path()));
 
     // following reads
     while let Some(path) = maybe_path {
@@ -1155,7 +1154,7 @@ where
 
         maybe_path = syscall!(w.trussed.read_dir_next())
             .entry
-            .map(|entry| PathBuf::try_from(entry.path()).unwrap());
+            .map(|entry| PathBuf::from(entry.path()));
     }
 
     // TODO finish

src/lib/ctap_app.rs

@@ -212,8 +212,8 @@ where
                 PublicKeyCredentialUserEntity {
                     id: Bytes::from_slice(&[3u8; 16]).unwrap(),
                     icon: None,
-                    name: Some("name".try_into().unwrap()),
-                    display_name: Some("display".try_into().unwrap()),
+                    name: Some("name".into()),
+                    display_name: Some("display".into()),
                 }
             };
 

src/lib/transport.rs

@@ -377,7 +377,7 @@ where
 
     #[inline(never)]
     fn get_webcrypt_cmd(&self, keyh: &[u8]) -> Result<ExtWebcryptCmd, WebcryptError> {
-        let webcrypt: WebcryptRequest = keyh.try_into().map_err(|_| Error::BadFormat)?;
+        let webcrypt: WebcryptRequest = keyh.into();
         webcrypt.try_into()
     }
 

src/lib/types.rs

@@ -74,6 +74,7 @@ pub enum Error {
     AlreadyInDatabase = 0xF7,
     NotFound = 0xF8,
     AssertFailed = 0xF9,
+    #[allow(clippy::enum_variant_names)]
     InternalError = 0xFA,
     MemoryFull = 0xFB,
     NotImplemented = 0xFC,